Make -H 'Host: my-server' set Host Header on Requests#272
Closed
Make -H 'Host: my-server' set Host Header on Requests#272
Conversation
Collaborator
|
Hi @ryohare , |
Collaborator
|
Ah sorry missed the exception, this should work. Will add a few modifications and comments to it, thanks! |
Author
|
I saw the Host parameter being passed in for the VHost mode, so yeah, I added it as the else in the if. Parsed out the host in the constructor for minor perf increases. One thing I considered but would defer to the team here was adding the host parameter as an argument, like user-agent is. Just went with it as a header to make it a less significant user facing change.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found myself needing to dirbust with a custom host header to hit the right vhost. Couldnt find it in the tool, so I figured I'd add it.
It the libgobuster http client is initialized with a host header, req.Host will be set from the header value stored in the struct.
Opened and issue for this: #271.