Prevent 'Divide by zero' error when using 'rangeLowRatio' and' rangeHighRatio' criterias (issue OHDSI/Atlas#69).#3
Merged
Conversation
…ighRatio' criterias (issue OHDSI/Atlas#69). Adding 'rangeLowRatio' and 'rangeHighRatio' criterias may cause 'Divideby zero' error when running in Redshift even if WHERE clause contains a check that 'range_low' or 'range_high' is not equals to zero, i.e. WHERE C.range_high > 0.0000 AND (C.value_as_number / C.range_high) > 1.0000
chrisknoll
approved these changes
Sep 5, 2017
Collaborator
|
This is done, however, because you created this PR off of your own master branch, you might see a conflict when you sync your upstream. In the future, it's a good idea to create PRs off of feature or topic branches. |
Author
|
Thanks, I didn't know this |
ssuvorov-fls
pushed a commit
that referenced
this pull request
Oct 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding 'rangeLowRatio' and 'rangeHighRatio' criterias may cause 'Divideby zero' error when running in Redshift even if WHERE clause contains a check that 'range_low' or 'range_high' is not equals to zero, i.e.