Skip to content

created endpoints for getting entities with assigned tags#1948

Merged
ssuvorov-fls merged 16 commits into
masterfrom
issue-1946-additional_tag_endpoints
Jan 18, 2022
Merged

created endpoints for getting entities with assigned tags#1948
ssuvorov-fls merged 16 commits into
masterfrom
issue-1946-additional_tag_endpoints

Conversation

@ssuvorov-fls

@ssuvorov-fls ssuvorov-fls commented Oct 18, 2021

Copy link
Copy Markdown
Contributor

fixes #1946
all tags from service parameter list must pe assigned to entity

example of rest call

POST http://localhost:8080/WebAPI/cohort-characterization/byTags
Accept: application/json
Content-Type: application/json

{
"names": ["Tag 1", "Tag 4"]
}

security must be disabled in AtlasSecurity.setupProtectedPath for manual testing
addRestPath("/cohort-characterization/byTags")

@anton-abushkevich anton-abushkevich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed some issues (see 520947b):

  • wrong permissions (byTag instead of byTags)
  • add null checks

@ssuvorov-fls ssuvorov-fls merged commit 51f5671 into master Jan 18, 2022
@delete-merged-branch delete-merged-branch Bot deleted the issue-1946-additional_tag_endpoints branch January 18, 2022 09:39
m0nhawk pushed a commit to uc-cdis/WebAPI that referenced this pull request Jan 26, 2022
* Implemented logic of reusable components and their tagging

* renamed migration script

* Reusables implementation - fixes and additions (Atlas #2623)

* Cohort exit date text is wrong in Atlas > Prediction > Population settings #2622 (OHDSI#1944)

(cherry picked from commit af00e1c)

* added versioning to reusables(OHDSI#1939)

* Reusables implementation (#2623) WIP

* moved some permissions to role "moderator"(OHDSI#1939)

* fixed after review(OHDSI#1939)

* added endpoint for copying reusable(OHDSI#1939)

* created endpoints for getting entities with assigned tags(OHDSI#1946)

* enabled security for new endpoints(OHDSI#1946)

* revert server.port configuration

* created endpoints for getting entities with assigned tags(OHDSI#1946) - fixes

Co-authored-by: Sergey Suvorov <[email protected]>
Co-authored-by: Anton Abushkevich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create endpoints in tagged entities

2 participants