Skip to content

javax.ws.rs.ForbiddenException in alert if user does not have vocabulary data source role #2568#1902

Merged
ssuvorov-fls merged 1 commit into
masterfrom
issue-2568_concept_set_forbidden_message
Jun 22, 2021
Merged

javax.ws.rs.ForbiddenException in alert if user does not have vocabulary data source role #2568#1902
ssuvorov-fls merged 1 commit into
masterfrom
issue-2568_concept_set_forbidden_message

Conversation

@anton-abushkevich

@anton-abushkevich anton-abushkevich commented Jun 22, 2021

Copy link
Copy Markdown
Contributor

@ssuvorov-fls ssuvorov-fls merged commit ebd4a5e into master Jun 22, 2021
@delete-merged-branch delete-merged-branch Bot deleted the issue-2568_concept_set_forbidden_message branch June 22, 2021 10:11
anton-abushkevich added a commit that referenced this pull request Jun 22, 2021
…ary data source role #2568 (#1902)

(cherry picked from commit ebd4a5e)
@blootsvoets

Copy link
Copy Markdown
Contributor

This PR broke some unit tests. @anton-abushkevich could you please fix the tests
CohortCharacterizationServiceTest.testExportGeneration and CohortCharacterizationServiceTest.testExportGenerationWithStrata? See
https://github.com/OHDSI/WebAPI/runs/2882977025?check_suite_focus=true
for the CI result.

@anton-abushkevich

Copy link
Copy Markdown
Contributor Author

These tests passed in my local env and in Jenkins. The problem only happens in github check suite. It has something to do with temp directory on the server where build runs, assertion fails in this line: https://github.com/OHDSI/WebAPI/blob/master/src/test/java/org/ohdsi/webapi/cohortcharacterization/CohortCharacterizationServiceTest.java#L147.

I do not sure why, but checks for other PRs (prior to this PR) were running with maven.test.skip=true, for example https://github.com/OHDSI/WebAPI/pull/1898/checks?check_run_id=2802600666. That is why checks in other PRs are green.

@blootsvoets

Copy link
Copy Markdown
Contributor

Thanks for the followup! I've made a PR to disable the unit tests altogether.

@anthonysena anthonysena added this to the v2.10.0 milestone Aug 17, 2021
m0nhawk pushed a commit to uc-cdis/WebAPI that referenced this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

javax.ws.rs.ForbiddenException in alert if user does not have vocabulary data source role

4 participants