Skip to content

merge geo spatial into 2.8#1509

Merged
wivern merged 6 commits into
masterfrom
issue-1445-merge-geo-spatial
Aug 19, 2020
Merged

merge geo spatial into 2.8#1509
wivern merged 6 commits into
masterfrom
issue-1445-merge-geo-spatial

Conversation

@ssuvorov-fls

Copy link
Copy Markdown
Contributor

fixes #1445

@ssuvorov-fls ssuvorov-fls requested a review from wivern April 14, 2020 14:19
@YaroslavTir YaroslavTir self-assigned this May 19, 2020
Comment thread README.md Outdated
Comment thread README.md
Comment thread pom.xml
@wivern wivern merged commit e8220f6 into master Aug 19, 2020
@wivern wivern deleted the issue-1445-merge-geo-spatial branch August 19, 2020 17:47
@chrisknoll

Copy link
Copy Markdown
Collaborator

This migration fails on sql server:

Message    : The multi-part identifier "ohdsi.sec_permission_id_seq.nextval" could not be bound.
Location   : db/migration/sqlserver/V2.8.0.20200413150815__gis_service_api.sql (C:\Git\WebAPI\target\classes\db\migration\sqlserver\V2.8.0.20200413150815__gis_service_api.sql)

The proper syntax for accessing the next value of a sequence is:
NEXT VALUE FOR ${ohdsiSchema}.{sequence name}

This is the problem line:

INSERT INTO ${ohdsiSchema}.sec_permission(id, value, description) VALUES
  (${ohdsiSchema}.sec_permission_id_seq.nextval, 'gis:cohort:*:bounds:*:get', 'Get gis bounds for source');

Which should be:

INSERT INTO ${ohdsiSchema}.sec_permission(id, value, description) VALUES
  (NEXT VALUE FOR ${ohdsiSchema}.sec_permission_id_seq, 'gis:cohort:*:bounds:*:get', 'Get gis bounds for source');

This may be a case where this is a syntax supported in later versions of MSSQL, but it is not supported by the local version of SqlServer I have installed (2016 SP2), which should still be a supported platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Geospaital functionality merge into 2.8

7 participants