Skip to content

Align required Impala driver version to installed version. Make them consistent with README#1280

Merged
wivern merged 1 commit into
rc-2.7.3from
fix-impala-install
Aug 6, 2019
Merged

Align required Impala driver version to installed version. Make them consistent with README#1280
wivern merged 1 commit into
rc-2.7.3from
fix-impala-install

Conversation

@pavgra

@pavgra pavgra commented Aug 6, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes #1282

@pavgra pavgra requested a review from wivern August 6, 2019 17:26
wivern
wivern requested changes Aug 6, 2019
View reviewed changes

@wivern wivern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why not the latest version which now is 2.6.12?

@pavgra

pavgra commented Aug 6, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Because 1) I'm a bit afraid of raising not patch version before release (of 2.7.3), 2) there was a switch from multiple driver-related JAR files to a single file in 2.5.* -> 2.6.*, which also would require additional changes - see 1. And the PR just cleans up todays drivers usage

@pavgra

pavgra commented Aug 6, 2019

Copy link
Copy Markdown
Contributor Author

Straightforward switch to 2.6.12 gives:

Caused by: java.sql.SQLException: Error message not found: NOT_IMPLEMENTED. Can't find resource for bundle java.util.PropertyResourceBundle, key NOT_IMPLEMENTED
	at com.cloudera.impala.hivecommon.dataengine.HiveJDBCDataEngine.prepareBatch(Unknown Source)
	at com.cloudera.impala.jdbc.common.SStatement.executeAnyBatch(Unknown Source)
	at com.cloudera.impala.jdbc.common.SStatement.executeBatch(Unknown Source)
	at org.ohdsi.webapi.util.CancelableJdbcTemplate$1BatchUpdateStatementCallback.doInStatement(CancelableJdbcTemplate.java:57)
	at org.ohdsi.webapi.util.CancelableJdbcTemplate$1BatchUpdateStatementCallback.doInStatement(CancelableJdbcTemplate.java:43)
	at org.springframework.jdbc.core.JdbcTemplate.execute(JdbcTemplate.java:407)
	at org.ohdsi.webapi.util.CancelableJdbcTemplate.batchUpdate(CancelableJdbcTemplate.java:96)
	at org.ohdsi.webapi.common.generation.CancelableTasklet.lambda$doTask$0(CancelableTasklet.java:35)
	at java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:266)
	at java.util.concurrent.FutureTask.run(FutureTask.java)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
Caused by: com.cloudera.impala.support.exceptions.GeneralException: Error message not found: NOT_IMPLEMENTED. Can't find resource for bundle java.util.PropertyResourceBundle, key NOT_IMPLEMENTED
	... 12 more

I would not spend time this on getting this working right now

@wivern wivern merged commit 650538c into rc-2.7.3 Aug 6, 2019
@wivern wivern deleted the fix-impala-install branch August 6, 2019 22:07
anthonysena pushed a commit that referenced this pull request Aug 8, 2019
@pavgra @anthonysena
Back merge of fixes from 2.7.3 (#1287)
6722ef8 
* Remove produces annotation + minor improvements (#1232)
* Fix overlap logic.
Allow event cohort periods that start within the target cohort era.  Prior version required the event cohort era to start and end in the target cohort era.
When collapsing, ensure start-end dates span at least a day.
Use count_big when counting cohort events and pathways.
Pad end dates to make non-inclusive.
Added casts for impala
Added temp-table cleanup.
Fixes #779.

* Omit cohort expression from list. - Fixes #219.
* Added client cache directives to response header (#1231)
* Removed legacy service which exposed server side request forgery issue (#1241)
* Added handlers for unexpected errors (#1237)
* Restored Kerberos auth support (#1253)
* Fixes masquerading of credentials in PLE / PLP results (#1255)
* Better quotes handling
* exclude older sql render versions (#1259)
* Fix compatability of /cohortdefinition/{id} endpoint (#1262)
* fixes cycling dependencies (#1264)
* Fix grouping problem in bq (#1267) (#1269)
* Fixes failed Cohort Pathways on Impala (#1274)
* fixes counts as bigint
* fixes Pathways for BQ
* Fixes save of Cohort Definitions when criteria requiring narrower CDM range are added (#1278)
* Fixes timeout based invalidation of Execution Engine jobs (#1272)
* Fixes Impala drivers (#1280)
* Updates circe to newer release which resolves PLE issues on Impala
* Merge fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wivern wivern wivern approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pavgra @wivern