Execution Engine jobs are not invalidated automatically (#1268)#1272
Merged
Conversation
added 2 commits
August 1, 2019 13:50
- add scheduler class ExecutionEngineAnalysisStatusInvalidationScheduler, that is active only in case `execution.invalidation.maxage` and `execution.invalidation.period` are set - small improvements
- remove redundant Transaction annotation
pavgra
suggested changes
Aug 1, 2019
- invalidate job itself (only ExecutionEngineAnalysisStatus was invalidated until now)
Author
indeed, Only status was invalidated, but not a job. I fixed it with the last commit. |
pavgra
suggested changes
Aug 2, 2019
pavgra
left a comment
pavgra
left a comment
Contributor
There was a problem hiding this comment.
Same as before exit_message is empty. How have you tested it?
pavgra
suggested changes
Aug 2, 2019
pavgra
left a comment
pavgra
left a comment
Contributor
There was a problem hiding this comment.
Same as before exit_message is empty. How have you tested it?
Contributor
|
chrisknoll
reviewed
Aug 2, 2019
| @Component | ||
| public class JobInvalidator { | ||
|
|
||
| public static final String INVALIDATED_BY_SYSTEM_EXIT_CODE = "Invalidated by system"; |
Collaborator
There was a problem hiding this comment.
Is this a 'code' or a message?
Contributor
There was a problem hiding this comment.
Message. So I agree, would be good to rename the variable
- fix: empty exitMessage for failed task.
wivern
requested changes
Aug 5, 2019
added 2 commits
August 5, 2019 16:55
- reuse code from JobInvalidator - set execution.invalidation.maxage as 12 hours
- rename execution.invalidation.maxage -> execution.invalidation.maxage.hours - remove unused updateAnalysisStatus method
wivern
approved these changes
Aug 5, 2019
pavgra
approved these changes
Aug 6, 2019
anthonysena
pushed a commit
that referenced
this pull request
Aug 8, 2019
* Remove produces annotation + minor improvements (#1232) * Fix overlap logic. Allow event cohort periods that start within the target cohort era. Prior version required the event cohort era to start and end in the target cohort era. When collapsing, ensure start-end dates span at least a day. Use count_big when counting cohort events and pathways. Pad end dates to make non-inclusive. Added casts for impala Added temp-table cleanup. Fixes #779. * Omit cohort expression from list. - Fixes #219. * Added client cache directives to response header (#1231) * Removed legacy service which exposed server side request forgery issue (#1241) * Added handlers for unexpected errors (#1237) * Restored Kerberos auth support (#1253) * Fixes masquerading of credentials in PLE / PLP results (#1255) * Better quotes handling * exclude older sql render versions (#1259) * Fix compatability of /cohortdefinition/{id} endpoint (#1262) * fixes cycling dependencies (#1264) * Fix grouping problem in bq (#1267) (#1269) * Fixes failed Cohort Pathways on Impala (#1274) * fixes counts as bigint * fixes Pathways for BQ * Fixes save of Cohort Definitions when criteria requiring narrower CDM range are added (#1278) * Fixes timeout based invalidation of Execution Engine jobs (#1272) * Fixes Impala drivers (#1280) * Updates circe to newer release which resolves PLE issues on Impala * Merge fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1268
execution.invalidation.maxageandexecution.invalidation.periodare set