Adds support for Apache Hive LLAP#107
Merged
Merged
Conversation
# Conflicts: # README.md # inst/java/DatabaseConnector.jar
…sue-1168-hive-support
…sue-1168-hive-support
…sue-1168-hive-support
properly removed file
schuemie
reviewed
Feb 7, 2020
|
|
||
| ctasHack <- function(connection, qname, tempTable, varNames, fts, data, progressBar, oracleTempSchema) { | ||
| batchSize <- 1000 | ||
| batchSize <- (function(dbms) if (dbms %in% c("hive")) 750 else 1000)( attr(connection, "dbms") ) |
Member
There was a problem hiding this comment.
This is hard to read, for no reason. Please rewrite as
if (attr(connection, "dbms") == "hive") {
batchSize <- 750
} else {
batchSize <- 1000
}
Member
|
Looks good, and still runs on PDW. I would like you to make the 1 change I pointed out |
schuemie
approved these changes
Feb 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves OHDSI/WebAPI#1168