Add custom logo enhance url support#2796
Merged
Merged
Conversation
chrisknoll
previously approved these changes
Dec 13, 2022
chrisknoll
left a comment
chrisknoll
left a comment
Collaborator
There was a problem hiding this comment.
Approved but:
I noticed that since feedback title is now configurable, we loose i18n. Is that necessary? Does feedback title need to be configurable?
Contributor
Author
|
@chrisknoll |
chrisknoll
approved these changes
Dec 14, 2022
delete-merged-branch
Bot
deleted the
add_custom_logo_enhance_url_support
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2795
Added overridable config fields:
feedbackContacts- text before email linkfeedbackCustomHtmlTemplate- user-defined text block on the feedback pageshowCompanyInfo- turns on-off lower-left block with logocompanyInfoCustomHtmlTemplate- override default lower-left blockAdded placeholders for login and password text fields:
authProviders[n].loginPlaceholderauthProviders[n].passwordPlaceholder