Skip to content

Atlas 2.14.0 - Characterization - /user/refresh with 404 when user authentication not enabled #2899

Description

@harry-anton

Expected behavior

In 2.14.0 version of Atlas, can navigate to Characterizations section and browse any of existing characterization from the list displayed. Shall display selected characterization information.

(Likewise, creating New Characterization is problematic in the same way.)

Actual behavior

Pop-up dialog with message Error! Please see server logs for details. and blank page appears.

The culprit seems to be access attempt to /user/refresh endpoint when user authentication for the whole setup is not enabled.

Firefox console:

user-refresh-404-firefox-console

Tomcat access logs, IP redacted:

...
192.168.XX.YYY - - [13/Dec/2023:12:30:56 +0000] "GET /WebAPI/cohort-characterization/52/design HTTP/1.1" 200 1146
192.168.XX.YYY - - [13/Dec/2023:12:30:56 +0000] "GET /WebAPI/user/refresh HTTP/1.1" 404 5
192.168.XX.YYY - - [13/Dec/2023:12:31:18 +0000] "GET /WebAPI/notifications?hide_statuses= HTTP/1.1" 200 625
...

Steps to reproduce behavior

In 2.14.0 version of Atlas, navigate to Characterizations section and try to browse any of existing characterization from the list displayed. Problematic behaviour discovered by Marek Oja.

Possible fix

We used to fix a line in js/services/AuthAPI.js where instead

        if (!isPromisePending(refreshTokenPromise)) {

we use

        if (!isPromisePending(refreshTokenPromise) && (config.userAuthenticationEnabled)) {

Works fine for us, for now.

Related

user-refresh-refreshToken-in-loadCharacterizationDesign

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions