Skip to content

Include package-lock.json #2363

Description

@chgl

Expected behavior

The lockfile should be included to ensure consistent and performant builds, especially for CI.

time npm i
# ...
real    0m23.724s
user    0m0.000s
sys     0m0.077s
time npm ci
# ...
real    0m9.855s
user    0m0.015s
sys     0m0.046s

Actual behavior

The package-lock.json was removed in #1157. I haven't been able to replicate the issues described there. Any builds running on my local windows machine and within a docker build ran fine.

I can definitely create a PR with an updated .gitignore and package-lock.json.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions