Skip to content

[WIP][8.0][website_multi_image] Provide reusable templates for base_multi_image.#171

Merged
pedrobaeza merged 2 commits intoOCA:8.0from
yajo:multi_image
Mar 10, 2016
Merged

[WIP][8.0][website_multi_image] Provide reusable templates for base_multi_image.#171
pedrobaeza merged 2 commits intoOCA:8.0from
yajo:multi_image

Conversation

@yajo
Copy link
Copy Markdown
Member

@yajo yajo commented Feb 24, 2016

WIP until OCA/server-tools#374 is merged.

This just serves as a base for other modules based on website and base_multi_image. Provides some reusable templates and styling.

@rafaelbn

…image.

This just serves as a base for other modules based on `website` and `base_multi_image`.
To develop a module based on this one:

* See module ``website_event_multi_image`` as an example.
* Use the provided templates in frontend website views.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this sentence should be rewritten to:

Inherit from the provided QWeb templates for creating website views.

And then you can list the current views IDs with a little explanation of each.

@pedrobaeza
Copy link
Copy Markdown
Member

For the icon, you can overlap the current website icon over the base image.

@yajo
Copy link
Copy Markdown
Member Author

yajo commented Mar 9, 2016

OCA/server-tools#374 is merged. WIP no more please, and add needs review please.

@pedrobaeza
Copy link
Copy Markdown
Member

👍

1 similar comment
@andhit-r
Copy link
Copy Markdown
Member

👍

pedrobaeza added a commit that referenced this pull request Mar 10, 2016
[WIP][8.0][website_multi_image] Provide reusable templates for base_multi_image.
@pedrobaeza pedrobaeza merged commit 3711cd8 into OCA:8.0 Mar 10, 2016
@yajo yajo deleted the multi_image branch March 10, 2016 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants