[FIX] base_multi_image: Use env in uninstall_hook by lasley · Pull Request #677 · OCA/server-tools

lasley · 2016-12-26T20:21:40Z

Uninstall hook should use new API instead of old, which doesn’t exist anymore

This should fix the Travis fails in OCA/product-attribute#201

* Uninstall hook should use new API instead of old, which doesn’t exist anymore

pedrobaeza · 2016-12-26T20:22:54Z

base_multi_image/hooks.py

-    Image.unlink(cr, SUPERUSER_ID, ids)
+    env = api.Environment(cr, SUPERUSER_ID, dict())
+    Image = env["base_multi_image.image"]
+    ids = Image.search(env, [("owner_model", "=", model)])


Better to call the variable records or recs

pedrobaeza · 2016-12-26T20:24:08Z

registry still exists on v10: https://github.com/OCA/OCB/blob/10.0/odoo/modules/registry.py#L23.

What is the value of the argument registry passed to the function?

lasley · 2016-12-26T20:27:57Z

@pedrobaeza Registry is valid, I just figured that while the env was there I should use it. Is that not the case?

lasley · 2016-12-26T20:29:04Z

The real error I am circumventing is the cr, SUPERUSER_ID being sent into the .search method: https://travis-ci.org/OCA/product-attribute/jobs/180247258#L559 - the switch from registry just seemed like bonus while I was there honestly.

pedrobaeza · 2016-12-26T20:36:25Z

Have you tried to use directly registry, but without cr and SUPERUSER_ID?

lasley · 2016-12-26T20:48:15Z

Yeah but an environment is still required as the first argument, so I don't see the different from just using the environment itself. Both of these work:

    env = api.Environment(cr, SUPERUSER_ID, dict())
    Image = env["base_multi_image.image"]
    images = Image.search([("owner_model", "=", model)])
    images.unlink()

    env = api.Environment(cr, SUPERUSER_ID, dict())
    Image = registry["base_multi_image.image"]
    images = Image.search(env, [("owner_model", "=", model)])
    images.unlink()

But the former seems cleaner and more OOP IMO

I am about to double check all of this in a new install though just to make sure

pedrobaeza · 2016-12-26T20:53:02Z

OK, thanks for the tests.

lasley · 2016-12-26T20:56:23Z

Hmmm yeah ok so that worked too, without the env. In hindsight I'm actually not sure why it worked the first time around when I passed an env to the .search, but it definitely does.

Simplified version, which I'm pretty sure is what you were thinking of, is pushed. Confirmed it works too 😄

pedrobaeza

Yeah, indeed that was my idea.

To the merger: please squash on merge

lasley · 2017-01-10T19:09:31Z

@tedsalmon please review. Solves this - https://travis-ci.org/OCA/product-attribute/builds/190700970 from OCA/product-attribute#201

* [FIX] base_multi_image: Use env in uninstall_hook

Syncing from upstream OCA/server-tools (12.0)

* [FIX] base_multi_image: Use env in uninstall_hook

[FIX] base_multi_image: Use env in uninstall_hook

d9ea7e3

* Uninstall hook should use new API instead of old, which doesn’t exist anymore

lasley added bug needs review labels Dec 26, 2016

lasley added this to the 10.0 milestone Dec 26, 2016

pedrobaeza reviewed Dec 26, 2016

View reviewed changes

Rename recordset

47bfe35

Fix search usage

fe2d1b7

Switch to registry

98fee16

pedrobaeza approved these changes Dec 26, 2016

View reviewed changes

lasley mentioned this pull request Jan 10, 2017

[MIG][10.0] product_multi_image OCA/product-attribute#201

Closed

5 tasks

StefanRijnhart approved these changes Jan 16, 2017

View reviewed changes

StefanRijnhart merged commit 0addd55 into OCA:10.0 Jan 16, 2017

lasley deleted the hotfix/10.0/base_multi_image-uninstall_hook branch January 16, 2017 16:32

sebalix pushed a commit to osiell/server-tools that referenced this pull request Jan 23, 2017

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

ef219d6

* [FIX] base_multi_image: Use env in uninstall_hook

qtheuret pushed a commit to qtheuret/server-tools that referenced this pull request Jun 12, 2018

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

835c4a8

* [FIX] base_multi_image: Use env in uninstall_hook

qtheuret pushed a commit to qtheuret/server-tools that referenced this pull request Jun 12, 2018

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

ac185bf

* [FIX] base_multi_image: Use env in uninstall_hook

qtheuret pushed a commit to qtheuret/server-tools that referenced this pull request Jun 12, 2018

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

911bda3

* [FIX] base_multi_image: Use env in uninstall_hook

hugosantosred pushed a commit to factorlibre/server-tools that referenced this pull request Aug 20, 2018

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

bbff0ba

* [FIX] base_multi_image: Use env in uninstall_hook

devang-dreambits pushed a commit to devang-dreambits/server-tools that referenced this pull request Mar 4, 2019

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

f472a3e

* [FIX] base_multi_image: Use env in uninstall_hook

angelmoya pushed a commit to PESOL/server-tools that referenced this pull request Mar 7, 2019

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

482399c

* [FIX] base_multi_image: Use env in uninstall_hook

javierjcf pushed a commit to Comunitea/server-tools that referenced this pull request Sep 9, 2020

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

0cc169b

* [FIX] base_multi_image: Use env in uninstall_hook

hailangvn pushed a commit to hailangvn/server-tools that referenced this pull request May 16, 2021

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

3d62846

* [FIX] base_multi_image: Use env in uninstall_hook

TobiasSorg pushed a commit to AmetrasIntelligence/server-tools that referenced this pull request Nov 26, 2021

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

4936d1b

* [FIX] base_multi_image: Use env in uninstall_hook

hailangvn pushed a commit to hailangvn/server-tools that referenced this pull request Jan 24, 2022

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

8fe2fb3

* [FIX] base_multi_image: Use env in uninstall_hook

flachica pushed a commit to flachica/server-tools that referenced this pull request May 6, 2022

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

dcc0e5a

* [FIX] base_multi_image: Use env in uninstall_hook

flachica pushed a commit to flachica/server-tools that referenced this pull request May 6, 2022

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

62cf7d3

* [FIX] base_multi_image: Use env in uninstall_hook

flachica pushed a commit to flachica/server-tools that referenced this pull request May 17, 2022

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

2f4751b

* [FIX] base_multi_image: Use env in uninstall_hook

mtelahun pushed a commit to mtelahun/server-tools that referenced this pull request Sep 5, 2022

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

e91a17f

* [FIX] base_multi_image: Use env in uninstall_hook

clb-openfire pushed a commit to odof/server-tools that referenced this pull request Apr 4, 2023

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

7a293f0

* [FIX] base_multi_image: Use env in uninstall_hook

yibudak pushed a commit to yibudak/server-tools that referenced this pull request Apr 26, 2023

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

ca381ee

* [FIX] base_multi_image: Use env in uninstall_hook

Ricardoalso pushed a commit to camptocamp/server-tools that referenced this pull request Sep 19, 2023

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

2ab79b5

* [FIX] base_multi_image: Use env in uninstall_hook

omalbastin pushed a commit to omalbastin/server-tools that referenced this pull request Jan 5, 2024

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

61de1e4

* [FIX] base_multi_image: Use env in uninstall_hook

IJOL pushed a commit to BITVAX/server-tools that referenced this pull request Aug 9, 2024

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

a5b3ae4

* [FIX] base_multi_image: Use env in uninstall_hook

IJOL pushed a commit to BITVAX/server-tools that referenced this pull request Aug 19, 2024

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

f881b06

* [FIX] base_multi_image: Use env in uninstall_hook

IJOL pushed a commit to BITVAX/server-tools that referenced this pull request Aug 19, 2024

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

727b23e

* [FIX] base_multi_image: Use env in uninstall_hook

psugne pushed a commit to versada/server-tools that referenced this pull request Oct 9, 2024

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

e1719f6

* [FIX] base_multi_image: Use env in uninstall_hook

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024

Merge pull request OCA#677 from OCA/12.0

67640f2

Syncing from upstream OCA/server-tools (12.0)

yibudak pushed a commit to yibudak/server-tools that referenced this pull request Dec 23, 2024

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

d861b23

* [FIX] base_multi_image: Use env in uninstall_hook

yibudak pushed a commit to yibudak/server-tools that referenced this pull request Dec 23, 2024

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

62259ee

* [FIX] base_multi_image: Use env in uninstall_hook

yibudak pushed a commit to yibudak/server-tools that referenced this pull request Dec 23, 2024

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

dae3d7e

* [FIX] base_multi_image: Use env in uninstall_hook

aaltinisik pushed a commit to altinkaya-opensource/server-tools that referenced this pull request Jan 13, 2025

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

700ee9a

* [FIX] base_multi_image: Use env in uninstall_hook

aaltinisik pushed a commit to altinkaya-opensource/server-tools that referenced this pull request Jan 13, 2025

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

d3be68a

* [FIX] base_multi_image: Use env in uninstall_hook

aaltinisik pushed a commit to altinkaya-opensource/server-tools that referenced this pull request Jan 13, 2025

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

9e26f37

* [FIX] base_multi_image: Use env in uninstall_hook

oerp-odoo pushed a commit to versada/server-tools that referenced this pull request Feb 14, 2025

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

fffe13c

* [FIX] base_multi_image: Use env in uninstall_hook

BhaveshHeliconia pushed a commit to HeliconiaIO/server-tools that referenced this pull request Feb 24, 2025

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

4c86730

* [FIX] base_multi_image: Use env in uninstall_hook

BhaveshHeliconia pushed a commit to HeliconiaIO/server-tools that referenced this pull request Aug 19, 2025

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

92717e0

* [FIX] base_multi_image: Use env in uninstall_hook

BhaveshHeliconia pushed a commit to HeliconiaIO/server-tools that referenced this pull request Jan 12, 2026

[FIX] base_multi_image: Use env in uninstall_hook (OCA#677)

82427e2

* [FIX] base_multi_image: Use env in uninstall_hook

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[FIX] base_multi_image: Use env in uninstall_hook#677

[FIX] base_multi_image: Use env in uninstall_hook#677
StefanRijnhart merged 4 commits intoOCA:10.0from
LasLabs:hotfix/10.0/base_multi_image-uninstall_hook

lasley commented Dec 26, 2016 •

edited

Loading

Uh oh!

pedrobaeza Dec 26, 2016

Uh oh!

pedrobaeza commented Dec 26, 2016

Uh oh!

lasley commented Dec 26, 2016

Uh oh!

lasley commented Dec 26, 2016 •

edited

Loading

Uh oh!

pedrobaeza commented Dec 26, 2016

Uh oh!

lasley commented Dec 26, 2016 •

edited

Loading

Uh oh!

pedrobaeza commented Dec 26, 2016

Uh oh!

lasley commented Dec 26, 2016 •

edited

Loading

Uh oh!

pedrobaeza left a comment

Uh oh!

lasley commented Jan 10, 2017 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

lasley commented Dec 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedrobaeza Dec 26, 2016

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Dec 26, 2016

Uh oh!

lasley commented Dec 26, 2016

Uh oh!

lasley commented Dec 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedrobaeza commented Dec 26, 2016

Uh oh!

lasley commented Dec 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedrobaeza commented Dec 26, 2016

Uh oh!

lasley commented Dec 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

lasley commented Jan 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lasley commented Dec 26, 2016 •

edited

Loading

lasley commented Dec 26, 2016 •

edited

Loading

lasley commented Dec 26, 2016 •

edited

Loading

lasley commented Dec 26, 2016 •

edited

Loading

lasley commented Jan 10, 2017 •

edited

Loading