[FIX][9.0] base_multi_image: Adhere to image delete bypass#628
Merged
pedrobaeza merged 1 commit intoOCA:9.0from Nov 30, 2016
Merged
Conversation
* Add catch in owner unlink to allow for image delete bypass via context
lasley
changed the title
This was referenced Nov 30, 2016
pedrobaeza
approved these changes
Nov 30, 2016
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
I don't know why this was removed in 9.0 migration, as in 8.0 it's present in https://github.com/OCA/server-tools/blob/8.0/base_multi_image/models/owner.py#L96...
Anyway, let's fast-track this to have it working again.
Contributor
|
Thank you @lasley ! |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (8.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At long last I have figured out the bug plaguing OCA/product-attribute#199, and it is actually in the base module. The images were being unlinked during the variant addition due to the call to super in the
unlinkmethod.It seems there was an intent for a context override, but it never made it into this module. It has now!