Skip to content

[15.0][MIG] base_multi_image#2334

Merged
OCA-git-bot merged 41 commits intoOCA:15.0from
flachica:15.0-mig-base_multi_image
Aug 8, 2022
Merged

[15.0][MIG] base_multi_image#2334
OCA-git-bot merged 41 commits intoOCA:15.0from
flachica:15.0-mig-base_multi_image

Conversation

@flachica
Copy link
Copy Markdown
Contributor

@flachica flachica commented May 6, 2022

@flachica flachica force-pushed the 15.0-mig-base_multi_image branch 2 times, most recently from 7c2e4c5 to d4d172b Compare May 6, 2022 12:01
@flachica flachica mentioned this pull request May 6, 2022
54 tasks
@rousseldenis
Copy link
Copy Markdown
Contributor

@flachica Thanks for this.

Could you update your last commit message in order to have something like '[15.0][MIG] base_multi_image'?

Copy link
Copy Markdown
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@flachica flachica force-pushed the 15.0-mig-base_multi_image branch from d4d172b to 265b006 Compare May 17, 2022 12:20
@flachica
Copy link
Copy Markdown
Contributor Author

@flachica Thanks for this.

Could you update your last commit message in order to have something like '[15.0][MIG] base_multi_image'?

Changed, thanks for your reviews

@jacekmichalski
Copy link
Copy Markdown

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Sorry @jacekmichalski you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@jacekmichalski
Copy link
Copy Markdown

@pedrobaeza isn't it ready to be merged?

Btw, what about OCA/product-attribute#1070 ?

@pedrobaeza
Copy link
Copy Markdown
Member

I miss a second review, but I suppose yours counts as second one. Please use the proper GitHub review mechanism.

/ocabot merge nobump
/ocabot migration base_multi_image

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-2334-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Aug 8, 2022
@OCA-git-bot OCA-git-bot merged commit b2e3765 into OCA:15.0 Aug 8, 2022
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 01440ce. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.