[MIG][16.0] Migration of vault_share#612
Conversation
fkantelberg
force-pushed
the
16.0-mig-vault_share
branch
from
af6bc63 to
f218f65
Compare
|
/ocabot migration vault_share |
|
Please rebase to get changes :) |
fkantelberg
force-pushed
the
16.0-mig-vault_share
branch
from
f218f65 to
42cb136
Compare
CarlosRoca13
left a comment
CarlosRoca13
left a comment
There was a problem hiding this comment.
It looks good to me 👍
|
@fkantelberg this one doesn't contain commit history. Please preserve it for also analyzing the specific changes done for 16.0 |
fkantelberg
force-pushed
the
16.0-mig-vault_share
branch
from
42cb136 to
bcdaa52
Compare
Fix website in manifest Run pre-commit Move models to own files. Apply OCA conventions Add application icon
…lect all possible users due to access rights - Disable the features if browser isn't using a secure context (https/localhost) - Load required assets in inbox and share frontends - Allow the user to switch a parent of an entry within the same vault - Allow to create entries for vaults using the main menu Entries - Fix bug that encrypted a share twice due to multiple extension with VaultAbstract - Fix a bug on share create that throws a warning about changed values
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-15.0/server-auth-15.0-vault_share Translate-URL: https://translation.odoo-community.org/projects/server-auth-15-0/server-auth-15-0-vault_share/
Currently translated at 17.0% (8 of 47 strings) Translation: server-auth-15.0/server-auth-15.0-vault_share Translate-URL: https://translation.odoo-community.org/projects/server-auth-15-0/server-auth-15-0-vault_share/nl/
Currently translated at 74.4% (35 of 47 strings) Translation: server-auth-15.0/server-auth-15.0-vault_share Translate-URL: https://translation.odoo-community.org/projects/server-auth-15-0/server-auth-15-0-vault_share/nl/
Currently translated at 87.2% (41 of 47 strings) Translation: server-auth-15.0/server-auth-15.0-vault_share Translate-URL: https://translation.odoo-community.org/projects/server-auth-15-0/server-auth-15-0-vault_share/es/
With the changes introduced on odoo/odoo@a251b14#diff-99de14b6e0a411718ac3adaaf779395155841c7ca9d95fa258369656dae63d18 the tests of vault and vault_share are failing.
fkantelberg
force-pushed
the
16.0-mig-vault_share
branch
from
bcdaa52 to
b511f1d
Compare
|
Yes I haven't used format-patch again and the commits were shared between the vault and vault_share PR. Was weird and I re-did the entire process. |
There was a problem hiding this comment.
New standard size is 140x140. Don't you have the SVG?
There was a problem hiding this comment.
There was never a svg and I'm not good enough with these tools. I just used https://spilymp.github.io/ibo/ again with the new size.
fkantelberg
force-pushed
the
16.0-mig-vault_share
branch
from
b511f1d to
f1b2a2b
Compare
fkantelberg
force-pushed
the
16.0-mig-vault_share
branch
from
f1b2a2b to
5b32c41
Compare
|
Let's not be more picky asking to squash this last commit, but there's no advantage in GitHub putting separate commits for new additions in a PR, and the commit history is a bit worse having them split. /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 41bab0e. Thanks a lot for contributing to OCA. ❤️ |
8 participants
Based on #611
The migration needed quite a rework because of the JS framework changes. (I hope the next are easier) I tested every functionality during migration but plan to do another round again soon.
There are some minor fixes which were possible to do: