Skip to content

[16.0][MIG] auth_oauth_multi_token#513

Closed
mlaitinen wants to merge 15 commits intoOCA:16.0from
mlaitinen:16.0-mig-auth_oauth_multi_token
Closed

[16.0][MIG] auth_oauth_multi_token#513
mlaitinen wants to merge 15 commits intoOCA:16.0from
mlaitinen:16.0-mig-auth_oauth_multi_token

Conversation

@mlaitinen
Copy link
Copy Markdown

  • Applied English capitalization rules in field names
  • Improved the res.users form by horizontally "unsqueezing" the list of auth tokens

@mlaitinen mlaitinen force-pushed the 16.0-mig-auth_oauth_multi_token branch 2 times, most recently from b099455 to 35637c6 Compare May 14, 2023 09:03
@mlaitinen
Copy link
Copy Markdown
Author

mlaitinen commented May 14, 2023

I didn't touch README.rst because IIRC it gets automatically generated once the PR is merged. Correct me if I'm wrong.

@pedrobaeza
Copy link
Copy Markdown
Member

/ocabot migration auth_oauth_multi_token

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone May 14, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request May 14, 2023
22 tasks
Copy link
Copy Markdown
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README is regenerated on merge, yes.


_name = "auth.oauth.multi.token"
_description = "OAuth2 token"
_description = "OAuth2 Token"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change existing capitalization. It's not incorrect as it was. Same comment for the rest of this kind of changes.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an OCA policy? If yes, could you please send me a link? Only remark about capitalization I could find is here: CONTRIBUTING.rst.

This is the way how titles in English are capitalized, and also how the names of all models & fields in Odoo are formatted.

@mlaitinen mlaitinen force-pushed the 16.0-mig-auth_oauth_multi_token branch from 35637c6 to 2c90556 Compare June 27, 2023 11:29
@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 29, 2023
@github-actions github-actions bot closed this Dec 3, 2023
SiesslPhillip pushed a commit to grueneerde/OCA-server-auth that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-auth (18.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants