[15.0][ADD] auth_saml: handle redirect parameter in the URI#483
Merged
OCA-git-bot merged 1 commit intoOCA:15.0from Sep 14, 2023
Merged
Conversation
vincent-hatakeyama
force-pushed
the
topic/15.0/auth_saml-add-handle-redirect
branch
6 times, most recently
from
aed03f9 to
bcc8c51
Compare
vincent-hatakeyama
force-pushed
the
topic/15.0/auth_saml-add-handle-redirect
branch
from
bcc8c51 to
f3426e1
Compare
vincent-hatakeyama
force-pushed
the
topic/15.0/auth_saml-add-handle-redirect
branch
from
f3426e1 to
16b420a
Compare
vincent-hatakeyama
force-pushed
the
topic/15.0/auth_saml-add-handle-redirect
branch
from
16b420a to
dde5c2c
Compare
Contributor
Author
|
/ocabot merge minor |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at d160eaa. Thanks a lot for contributing to OCA. ❤️ |
vincent-hatakeyama
deleted the
topic/15.0/auth_saml-add-handle-redirect
branch
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-auth
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-auth (17.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes #481
Unlike auth_oauth, this module did not handle redirect correctly.
For example, something like http://localhost:8069/web/login?redirect=%2Fweb%23menu_id%3D111%26action%3D176%26model%3Dmodel_name%26view_type%3Dlist would not keep the redirect part if SAML authentication was used. It would work as expected with the standard authentication or auth_oauth/auth_oidc.
The changes have been tested with a local keycloak.