[15.0][ADD] auth_saml: Improve login page#481
Merged
OCA-git-bot merged 1 commit intoOCA:15.0from Sep 14, 2023
Merged
Conversation
vincent-hatakeyama
force-pushed
the
topic/15.0/add-auth_saml-improve-login
branch
from
a9edf56 to
7fcd10a
Compare
vincent-hatakeyama
force-pushed
the
topic/15.0/add-auth_saml-improve-login
branch
2 times, most recently
from
0ad7abb to
5fe354f
Compare
theangryangel
approved these changes
May 31, 2023
vincent-hatakeyama
force-pushed
the
topic/15.0/add-auth_saml-improve-login
branch
from
5fe354f to
1206f61
Compare
Make the login page compatible with auth_oauth by using a differently named variable. Render the button with the similar classes and HTML as what is done by auth_oauth. That includes using the default CSS and adding translation for the button text.
vincent-hatakeyama
force-pushed
the
topic/15.0/add-auth_saml-improve-login
branch
from
1206f61 to
0dd018b
Compare
Contributor
Author
|
/ocabot merge minor |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 04fac75. Thanks a lot for contributing to OCA. ❤️ |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-auth
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-auth (17.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the login page compatible with auth_oauth by using a differently named variable.
Render the button with the similar classes and HTML as what is done by auth_oauth. That includes using the default CSS and adding translation for the button text.
Images of the Login buttons with both auth_oauth and auth_saml:
Before the changes:
After the changes: