Skip to content

[16.0][MIG] auth_oidc: Migration to 16.0#467

Merged
OCA-git-bot merged 34 commits intoOCA:16.0from
Ontinet-com:16.0-mig-auth_oidc
May 5, 2023
Merged

[16.0][MIG] auth_oidc: Migration to 16.0#467
OCA-git-bot merged 34 commits intoOCA:16.0from
Ontinet-com:16.0-mig-auth_oidc

Conversation

@jaenbox
Copy link
Copy Markdown

@jaenbox jaenbox commented Jan 27, 2023

Standard migration to 16.0

@jaenbox jaenbox force-pushed the 16.0-mig-auth_oidc branch from 3941afd to 4f4e412 Compare January 27, 2023 17:11
Abranes
Abranes approved these changes Jan 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Abranes Abranes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on keycloak on local.

adrienpeiffer
adrienpeiffer approved these changes Feb 13, 2023
View reviewed changes
Copy link
Copy Markdown

@adrienpeiffer adrienpeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review + tests

@adrienpeiffer
Copy link
Copy Markdown

adrienpeiffer commented Feb 13, 2023

@OCA/server-environment-maintainers could you merge this one ?

@adrienpeiffer
Copy link
Copy Markdown

adrienpeiffer commented Mar 3, 2023

@OCA/server-environment-maintainers No one ? 🙏

@ashuio
Copy link
Copy Markdown

ashuio commented Mar 21, 2023 •
edited
Loading

Any ETA on this merge? We are running EE and would really appreciate this fix.

@OCA/server-environment-maintainers

@theangryangel
Copy link
Copy Markdown
Member

theangryangel commented Apr 18, 2023

@jaenbox any chance this could be rebased? <3

andreschenkels and others added 22 commits April 18, 2023 17:18
@andreschenkels
[ADD] auth_oidc module
50801d5
@gurneyalex
Adapt to OCA standards
ef5d7a0 
update manifest, add README, update requirements.txt
@sbidoul
auth_oidc: improve docs
1ff819a 
Add some install instructions and configuration instructions
for keycloak.
@sbidoul
[MIG] auth_oidc: update dotfiles
854bbbd
@sbidoul
[MIG] auth_oidc from 10.0
db92f59
@sbidoul
auth_oidc: simplify and use "id_token token"
3241814 
Avoid replacing the access token by the id token.
This may cause confusion.
Copy a little piece of code from auth_oauth() method,
to make the code easier to follow, and prepare for
implementing the authorization code flow.
@sbidoul
auth_oidc: _get_key and _map_token_values are not model methods
b893d02
@sbidoul
auth_oidc: cache _get_key
a9de97f
@sbidoul
auth_oidc: add authorization code flow
0053599
@sbidoul
auth_oidc: separate field for jwks uri
32c609d
@sbidoul
auth_oidc: additional error logging
9fedb59
@sbidoul
auth_oidc: add author and maintainer
c166d9e
@sbidoul
auth_oidc: improve docs, mention implicit flow is not recommended
b4bcc16
@sbidoul
auth_oidc: better nonce
3ceb837
@sbidoul
auth_oidc: make client secret optional
050141c 
This is not a recommended scenario, but this prepares
the code for using PKCE
@sbidoul
auth_oidc: add PKCE support
45837db
@sbidoul
auth_oidc: demo data and basic test
3dbc6f8
@sbidoul
auth_oidc: slightly more robust parsing of claim mapping
3c31e28
@sbidoul
auth_oidc: split long method
73fa436
@oca-travis
[UPD] Update auth_oidc.pot
daa290e
@OCA-git-bot
[UPD] README.rst
e19fe8b
@OCA-git-bot
auth_oidc 13.0.1.0.1
893113a
@jaenbox jaenbox force-pushed the 16.0-mig-auth_oidc branch from 4f4e412 to 9483d8e Compare April 18, 2023 15:21
@jaenbox
Copy link
Copy Markdown
Author

jaenbox commented Apr 18, 2023

@jaenbox any chance this could be rebased? <3

done!!

@jaenbox jaenbox force-pushed the 16.0-mig-auth_oidc branch from 9483d8e to 41f7187 Compare April 18, 2023 15:28
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Apr 18, 2023

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@jaenbox jaenbox mentioned this pull request Apr 27, 2023
Open
22 tasks
theangryangel
theangryangel approved these changes Apr 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@theangryangel theangryangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally tested.

@CRogos
Copy link
Copy Markdown
Contributor

CRogos commented May 5, 2023

@gurneyalex could you have a look why this is not merged yet?

@jaenbox jaenbox force-pushed the 16.0-mig-auth_oidc branch from 41f7187 to 6be008e Compare May 5, 2023 14:34
@sbidoul
Copy link
Copy Markdown
Member

sbidoul commented May 5, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 5, 2023

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-467-by-sbidoul-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b4d3db1 into OCA:16.0 May 5, 2023
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 5, 2023

Congratulations, your PR was merged at 302a3a8. Thanks a lot for contributing to OCA. ❤️

@sbidoul
Copy link
Copy Markdown
Member

sbidoul commented Jun 6, 2023

/ocabot migration auth_oidc

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 6, 2023
SiesslPhillip pushed a commit to grueneerde/OCA-server-auth that referenced this pull request Nov 20, 2024
@bt-admin
Merge pull request OCA#467 from OCA/13.0
337c6a7 
Syncing from upstream OCA/server-auth (13.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@theangryangel theangryangel theangryangel approved these changes

@Abranes Abranes Abranes approved these changes

@adrienpeiffer adrienpeiffer adrienpeiffer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.