[14.0][FIX] auth_signup_verify_email: Use real email address for tests #388
[14.0][FIX] auth_signup_verify_email: Use real email address for tests #388OCA-git-bot merged 1 commit intoOCA:14.0from
Conversation
pedrobaeza
changed the title
|
@pedrobaeza the requirements.txt is now generated based on the modules |
pedrobaeza
changed the title
|
I'm just trying some things. Pinning doesn't serve for this case, but if it would serve, the option to "consolidate" it is to put that version in the manifest in the |
pedrobaeza
force-pushed
the
14.0-ci
branch
4 times, most recently
from
bd09f0e to
167dafb
Compare
I'm not sure what the problem is here, but to answer this specific question, I'm pretty sure you can put version specifiers in external_dependencies in Odoo >= 13. |
In one part of the CI pipeline, the IANA example domains are not accepted, getting this message from `email_validator` library: The domain name example.com does not accept email So we switch to a real domain for avoiding the problem, using our famous main OCA list address, which at the end, it's not secret and won't be disabled in a short future.
pedrobaeza
changed the title
|
At the end, I have needed to switch to a real email address for passing the tests, as example domain is no longer valid in the CI environment (it was passing in local environment though), but it's not a big deal. /ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at d715179. Thanks a lot for contributing to OCA. ❤️ |
Syncing from upstream OCA/server-auth (16.0)
4 participants
In one part of the CI pipeline, the IANA example domains are not accepted, getting this message from
email_validatorlibrary:The domain name example.com does not accept email
So we switch to a real domain for avoiding the problem, using our famous main OCA list address, which at the end, it's not secret and won't be disabled in a short future.
@Tecnativa