[MIG][15.0] auth_api_key: Migration to 15.0 by yankinmax · Pull Request #308 · OCA/server-auth

yankinmax · 2021-11-24T16:06:34Z

No description provided.

yankinmax · 2021-11-25T08:30:34Z

@lmignon Could you pls do the same OCA/connector#420 (comment) for https://github.com/OCA/server-auth as well ?

lmignon · 2021-11-25T09:23:04Z

@simahawk Why do you've deleted the 15.0 branch? I need it to redo the initialization... Unfortunately, I've no more time today to redo a proper initialization.

simahawk · 2021-11-25T09:38:02Z

@lmignon I take care, don't worry. I checked PRs and I didn't see any TBH :/
The branch is back.

simahawk · 2021-11-25T09:42:19Z

@lmignon the bare init is done already, that works w/ the mt tool. I wanted to generate it again from 14.0 w/ all modules uninstallable but it failed (and to do it you need to delete the branch apparently).

ivantodorovich

LG

simahawk

You might want to migrate auth_api_key_sever_env too

simahawk · 2021-11-26T07:00:31Z

/ocabot merge nobump

OCA-git-bot · 2021-11-26T07:00:36Z

@simahawk The merge process could not start, because command `git merge --no-ff -m Merge PR #308 into 15.0

Signed-off-by simahawk tmp-pr-308` failed with output:

fatal: refusing to merge unrelated histories

simahawk · 2021-11-26T07:18:16Z

@yankinmax seems I screwed history relation when deleting 15.0 (which was the only way to try the MT tool for generating a full branch). Could you rebase your work on current 15.0?

…custom one from shopinvader

Get rid of keychain dependency

Co-Authored-By: qgroulard <[email protected]>

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-14.0/server-auth-14.0-auth_api_key Translate-URL: https://translation.odoo-community.org/projects/server-auth-14-0/server-auth-14-0-auth_api_key/

dreispt · 2021-11-27T11:03:07Z

/ocabot merge nobump

OCA-git-bot · 2021-11-27T11:03:16Z

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-308-by-dreispt-bump-nobump, awaiting test results.

Signed-off-by dreispt

OCA-git-bot · 2021-11-27T11:06:51Z

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-308-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

yankinmax · 2021-11-29T11:21:47Z

@dreispt @simahawk can you pls try again to merge this PR?

simahawk · 2021-11-29T11:26:09Z

/ocabot merge nobump

OCA-git-bot · 2021-11-29T11:26:17Z

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-308-by-simahawk-bump-nobump, awaiting test results.

Signed-off-by simahawk

OCA-git-bot · 2021-11-29T11:29:52Z

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-308-by-simahawk-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

simahawk · 2021-11-29T11:32:35Z

@sbidoul could we disable caching for pre-commit to avoid such errors?

Error: reserveCache failed: Cache already exists. Scope: refs/heads/15.0-ocabot-merge-pr-308-by-simahawk-bump-nobump, Key: pre-commit-2-6e9292ce7484c9db39ab47966f1138e55cc541e71579416d61487d23def85a68-23b05f1a0616e9488a803945aa248b3968925367ec725f4d0f32e9d3a68935ac, Version: 28cdb9f5496f334116f23e86f0063f5d3a9348c2e22425a33171e071aadada7e

https://github.com/OCA/server-auth/runs/4352799172?check_suite_focus=true#step:4:125

They happen quite often.

OCA-git-bot · 2021-11-29T16:42:41Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

dreispt · 2021-11-29T20:43:36Z

/ocabot merge nobump

sbidoul · 2021-11-29T20:53:24Z

could we disable caching for pre-commit to avoid such errors?

@simahawk according to pre-commit/action#41 this is a race condition that is not fixable.
So I'm not sure we can fix it ourselves except by disabling the cache (which may or may not create perf issues).
Also the pre-commit GitHub action is unmaintained as the author is developing https://pre-commit.ci/
Last time I checked https://pre-commit.ci/ was not usable for us as it tries to autoupdate the pre-commit configs, which we don't want. Also our big pre-commit runs (with pylint-odoo and such) would probably kill the guy's free-for-opensource budget. But we may want to reach out to see if there are options.

simahawk · 2021-11-30T12:22:40Z

So I'm not sure we can fix it ourselves except by disabling the cache (which may or may not create perf issues).

Shall we give it a try?

Meanwhile I got this merged here #311

Syncing from upstream OCA/server-auth (12.0)

simahawk deleted the branch OCA:15.0 November 25, 2021 09:12

simahawk closed this Nov 25, 2021

simahawk reopened this Nov 25, 2021

ivantodorovich approved these changes Nov 25, 2021

View reviewed changes

simahawk approved these changes Nov 26, 2021

View reviewed changes

OCA-git-bot added the approved label Nov 26, 2021

lmignon and others added 17 commits November 26, 2021 12:03

New generic module du define REST services

58e8260

auth_api_key: New module to provide authentication by api_key

5cd5f8d

auth_api_key: Remove useless code

52b4d3c

Update the auth_api_key for keychan 10.0.2 (renamed method)

f26e728

Fix the authentification method and show the user_id on the form

1ed30e7

refactor code in order to use generic code from base_rest instead of …

f4ee2e4

…custom one from shopinvader

fix wrong name in selection box

1cd1e8c

Since keychain 10.0.2.0.1 there is a default validation method

92ee605

Keychain removed

d13d8c7

Get rid of keychain dependency

Update Readme with more details

d1bb071

Quick fix CONFIGURE.rst

9808673

Developmet status: Beta

24bcea6

[FIX] auth_api_key: fix api and flake8

d9fec16

[MIG] server_auth from 10 to 12

6807293

auth_api_key: add description to model

1edf895

[CHG] auth_api_key is LGPL

31834ac

Use consteq to compare keys

419e8b0

Co-Authored-By: qgroulard <[email protected]>

OCA-git-bot and others added 3 commits November 26, 2021 12:03

auth_api_key 14.0.2.0.1

e4fa119

[IMP] auth_api_key: black, isort, prettier

9562587

yankinmax force-pushed the 15.0-mig-auth_api_key branch from 26dd85f to 883452a Compare November 26, 2021 10:04

This was referenced Nov 26, 2021

[15.0][MIG] base_rest_auth_api_key: Migration to 15.0 OCA/rest-framework#226

Merged

[15.0][MIG] auth_api_key_server_env: Migration to 15.0 #310

Merged

OCA-git-bot added a commit that referenced this pull request Nov 27, 2021

Merge PR #308 into 15.0

6009509

Signed-off-by dreispt

OCA-git-bot added the bot is merging ⏳ label Nov 27, 2021

OCA-git-bot removed the bot is merging ⏳ label Nov 27, 2021

[MIG] auth_api_key: Migration to 15.0

4dcb8c4

yankinmax force-pushed the 15.0-mig-auth_api_key branch from 883452a to 4dcb8c4 Compare November 29, 2021 11:12

OCA-git-bot added a commit that referenced this pull request Nov 29, 2021

Merge PR #308 into 15.0

ddaf658

Signed-off-by simahawk

OCA-git-bot added the bot is merging ⏳ label Nov 29, 2021

OCA-git-bot removed the bot is merging ⏳ label Nov 29, 2021

OCA-git-bot added the ready to merge label Nov 29, 2021

simahawk mentioned this pull request Nov 30, 2021

[MIG][15.0] auth_api_key: Migration to 15.0 #311

Merged

OCA-git-bot merged commit 1c351be into OCA:15.0 Nov 30, 2021

SiesslPhillip pushed a commit to grueneerde/OCA-server-auth that referenced this pull request Nov 20, 2024

Merge pull request OCA#308 from OCA/12.0

9b90ad2

Syncing from upstream OCA/server-auth (12.0)

Uh oh!

Conversation

yankinmax commented Nov 24, 2021

Uh oh!

yankinmax commented Nov 25, 2021

Uh oh!

lmignon commented Nov 25, 2021

Uh oh!

simahawk commented Nov 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simahawk commented Nov 25, 2021

Uh oh!

ivantodorovich left a comment

Choose a reason for hiding this comment

Uh oh!

simahawk left a comment

Choose a reason for hiding this comment

Uh oh!

simahawk commented Nov 26, 2021

Uh oh!

OCA-git-bot commented Nov 26, 2021

Uh oh!

simahawk commented Nov 26, 2021

Uh oh!

dreispt commented Nov 27, 2021

Uh oh!

OCA-git-bot commented Nov 27, 2021

Uh oh!

OCA-git-bot commented Nov 27, 2021

Uh oh!

yankinmax commented Nov 29, 2021

Uh oh!

simahawk commented Nov 29, 2021

Uh oh!

OCA-git-bot commented Nov 29, 2021

Uh oh!

OCA-git-bot commented Nov 29, 2021

Uh oh!

simahawk commented Nov 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OCA-git-bot commented Nov 29, 2021

Uh oh!

dreispt commented Nov 29, 2021

Uh oh!

sbidoul commented Nov 29, 2021

Uh oh!

simahawk commented Nov 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

simahawk commented Nov 25, 2021 •

edited

Loading

simahawk commented Nov 29, 2021 •

edited

Loading