[11.0][ADD] Auth SAML create users by eilst · Pull Request #113 · OCA/server-auth

eilst · 2019-06-10T17:49:58Z

No description provided.

eilst · 2019-06-10T21:07:18Z

I could add a docker-compose.yml with an idp configured with odoo as sp for functional tests. Is it a good idea?

eilst · 2019-06-28T18:46:38Z

Hey @max3903 @pedrobaeza @vincent-hatakeyama, I added this feature of giving the option to automatically create a user when he logs in with an idp. I base this pr on @vincent-hatakeyama, which fixes some important issues that exist on 11.0.

eilst · 2019-06-28T18:50:46Z

The runbot fails with when building the docker image
ERROR: /bin/sh: 1: mysql_config: not found
Traceback (most recent call last):...
File "/tmp/pip-install-lro6f39d/mysqlclient/setup_posix.py", line 29, in mysql_config
raise EnvironmentError("%s not found" % (_mysql_config_path,))
OSError: mysql_config not found
I think is something with the dockerfile, right?

oca_dependencies.txt

auth_saml_create_user/models/auth_saml.py

auth_saml_create_user/models/res_users.py

auth_saml_create_user/models/auth_saml.py

wbeverly

Approved!

eilst · 2019-08-14T14:59:48Z

@bodedra @max3903 This module is ready with unit tests added. Could you merge it?

OCA-git-bot · 2019-08-14T15:00:06Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

bodedra

Add manor comments.

auth_saml_create_user/__manifest__.py

auth_saml_create_user/models/res_users.py

oca-clabot · 2019-08-21T16:03:34Z

Hey @eilst, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

lgarcia [email protected] (no github login found)

Appreciation of efforts,
OCA CLAbot

vincent-hatakeyama · 2019-08-23T14:13:26Z

Why is there a mix of LGPL and AGPL code in the module? It has always been AGPL, I don’t think LGPL can be added into it.

I also don’t think you can change license of the code like indicated in #113 (comment)

eilst · 2019-08-26T16:50:15Z

Why is there a mix of LGPL and AGPL code in the module? It has always been AGPL, I don’t think LGPL can be added into it.

I also don’t think you can change license of the code like indicated in #113 (comment)

Right, I rebased the branch with the correct license. In other projects that I work they use LGPL, so I did a mistake in some file headers.
I also read this in https://odoo-community.org/page/faq :
Why most of the OCA code base is AGPL ?
Because the AGPL license is the only license considering someone connecting to Odoo as a user. It protects companies from being locked in by their Odoo hosting provider. Finally, Odoo was fully AGPL for years and lots of devs has been released under the license by then.

eilst · 2019-08-28T14:09:18Z

Now, everything should be fine. License, tests, code coverage, travis checks, corrections from comments, main feature. Could you merge it please @pedrobaeza?

max3903 · 2019-09-30T16:26:36Z

/ocabot merge

OCA-git-bot · 2019-09-30T16:26:45Z

On my way to merge this fine PR!
Prepared branch 11.0-ocabot-merge-pr-113-by-max3903-bump-no, awaiting test results.

Signed-off-by max3903

OCA-git-bot · 2019-10-01T02:03:26Z

@max3903 your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-113-by-max3903-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot · 2019-10-01T08:06:44Z

On my way to merge this fine PR!
Prepared branch 11.0-ocabot-merge-pr-113-by-moylop260-bump-no, awaiting test results.

Signed-off-by moylop260

OCA-git-bot · 2019-10-01T12:02:55Z

@moylop260 your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-113-by-moylop260-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

moylop260 · 2019-10-01T13:57:21Z

/ocabot merge

There is still a flaky error

OCA-git-bot · 2019-10-01T13:57:39Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 11.0-ocabot-merge-pr-113-by-moylop260-bump-no, awaiting test results.

Signed-off-by moylop260

OCA-git-bot · 2019-10-01T17:56:57Z

@moylop260 your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-113-by-moylop260-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

moylop260 · 2019-10-12T04:12:38Z

/ocabot merge

OCA-git-bot · 2019-10-12T06:06:03Z

On my way to merge this fine PR!
Prepared branch 11.0-ocabot-merge-pr-113-by-moylop260-bump-no, awaiting test results.

Signed-off-by moylop260

OCA-git-bot · 2019-10-12T06:29:56Z

@moylop260 your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-113-by-moylop260-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

eilst · 2019-11-08T19:32:32Z

/ocabot merge

OCA-git-bot · 2019-11-08T19:32:45Z

Sorry @eilst you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

[FIX] Flake8 & pylint [FIX] manifest [FIX] manifest [UPD] auth_saml_create_user/models/auth_saml.py Co-Authored-By: Rim BEN DHAOU <[email protected]> Apply suggestions from code review [ADD] Tests [ADD] Tests [ADD] Starting random password [FIX Imports and pep8] [UPD] Tests [FIX] empty password [FIX] exception not needed [FIX] password not needed in write [UPD] Create saml pass string [ADD] test secret problem [FIX] secret null [ADD]tests: teradown method [FIX] not need teardown [FIX] manifest [FIX] License [FIX] Maintainers and development_status Update __manifest__.py

moylop260 · 2019-11-28T23:24:01Z

@eilst
I just detected the red error of the CI.

Fixing in the following PR:

[FIX] auth_saml: Fix KeyError using auth_oauth module. #149

moylop260 · 2019-11-29T15:46:44Z

/ocabot merge

OCA-git-bot · 2019-11-29T15:46:57Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 11.0-ocabot-merge-pr-113-by-moylop260-bump-no, awaiting test results.

Signed-off-by moylop260

OCA-git-bot · 2019-11-29T16:45:18Z

It looks like something changed on 11.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 11.0-ocabot-merge-pr-113-by-moylop260-bump-no, awaiting test results.

Signed-off-by moylop260

OCA-git-bot · 2019-11-29T17:21:27Z

Congratulations, your PR was merged at 8e5cd17. Thanks a lot for contributing to OCA. ❤️

Syncing from upstream OCA/server-auth (11.0)

eilst changed the title ~~[ADD] Auth SAML create users~~ [11.0][ADD] Auth SAML create users Jun 10, 2019

lgharib approved these changes Jun 28, 2019

View reviewed changes

eilst force-pushed the 11.0-add-auth_saml_create_user branch from 78d1428 to a6ee3f0 Compare July 22, 2019 18:12

eilst commented Jul 22, 2019

View reviewed changes

oca_dependencies.txt Outdated Show resolved Hide resolved

eilst force-pushed the 11.0-add-auth_saml_create_user branch from 59781bb to f89bf01 Compare July 23, 2019 15:43

rimbendhaou reviewed Jul 23, 2019

View reviewed changes

auth_saml_create_user/models/auth_saml.py Show resolved Hide resolved

auth_saml_create_user/models/auth_saml.py Outdated Show resolved Hide resolved

auth_saml_create_user/models/res_users.py Show resolved Hide resolved

eilst commented Jul 23, 2019

View reviewed changes

auth_saml_create_user/models/auth_saml.py Show resolved Hide resolved

wbeverly approved these changes Jul 30, 2019

View reviewed changes

OCA-git-bot added the approved label Jul 30, 2019

eilst force-pushed the 11.0-add-auth_saml_create_user branch 3 times, most recently from 88661df to aacbb98 Compare August 12, 2019 15:39

OCA-git-bot added the ready to merge label Aug 14, 2019

bodedra reviewed Aug 15, 2019

View reviewed changes

auth_saml_create_user/__manifest__.py Outdated Show resolved Hide resolved

auth_saml_create_user/__manifest__.py Outdated Show resolved Hide resolved

auth_saml_create_user/models/res_users.py Show resolved Hide resolved

eilst force-pushed the 11.0-add-auth_saml_create_user branch from 118391d to bb20cd7 Compare August 21, 2019 19:01

eilst force-pushed the 11.0-add-auth_saml_create_user branch from bb20cd7 to dfeca4a Compare August 26, 2019 16:46

eilst force-pushed the 11.0-add-auth_saml_create_user branch from dfeca4a to 4196f32 Compare August 26, 2019 20:56

OCA-git-bot added a commit that referenced this pull request Sep 30, 2019

Merge PR #113 into 11.0

a9b54e5

Signed-off-by max3903

OCA-git-bot added a commit that referenced this pull request Oct 1, 2019

Merge PR #113 into 11.0

94af19b

Signed-off-by moylop260

OCA-git-bot added a commit that referenced this pull request Oct 1, 2019

Merge PR #113 into 11.0

bde8b02

Signed-off-by moylop260

OCA-git-bot added a commit that referenced this pull request Oct 12, 2019

Merge PR #113 into 11.0

9672789

Signed-off-by moylop260

eilst force-pushed the 11.0-add-auth_saml_create_user branch 2 times, most recently from 2460b12 to 514b02b Compare November 8, 2019 17:40

eilst force-pushed the 11.0-add-auth_saml_create_user branch from 3c83d1e to 6be137f Compare November 25, 2019 19:13

Luis added 2 commits November 25, 2019 15:05

[ADD] Auth SAML create users

149e280

eilst force-pushed the 11.0-add-auth_saml_create_user branch from 6be137f to ad0b33c Compare November 25, 2019 20:05

moylop260 mentioned this pull request Nov 28, 2019

[FIX] auth_saml: Fix KeyError using auth_oauth module. #149

Merged

OCA-git-bot added a commit that referenced this pull request Nov 29, 2019

Merge PR #113 into 11.0

7dfab15

Signed-off-by moylop260

OCA-git-bot added a commit that referenced this pull request Nov 29, 2019

Merge PR #113 into 11.0

11daa75

Signed-off-by moylop260

OCA-git-bot merged commit ad0b33c into OCA:11.0 Nov 29, 2019

OCA-git-bot added the merged 🎉 label Nov 29, 2019

SiesslPhillip pushed a commit to grueneerde/OCA-server-auth that referenced this pull request Nov 20, 2024

Merge pull request OCA#113 from OCA/11.0

b7f6617

Syncing from upstream OCA/server-auth (11.0)

Uh oh!

Conversation

eilst commented Jun 10, 2019

Uh oh!

eilst commented Jun 10, 2019

Uh oh!

eilst commented Jun 28, 2019

Uh oh!

eilst commented Jun 28, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wbeverly left a comment

Choose a reason for hiding this comment

Uh oh!

eilst commented Aug 14, 2019

Uh oh!

OCA-git-bot commented Aug 14, 2019

Uh oh!

bodedra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oca-clabot commented Aug 21, 2019

Uh oh!

vincent-hatakeyama commented Aug 23, 2019

Uh oh!

eilst commented Aug 26, 2019

Uh oh!

eilst commented Aug 28, 2019

Uh oh!

max3903 commented Sep 30, 2019

Uh oh!

OCA-git-bot commented Sep 30, 2019

Uh oh!

OCA-git-bot commented Oct 1, 2019

Uh oh!

OCA-git-bot commented Oct 1, 2019

Uh oh!

OCA-git-bot commented Oct 1, 2019

Uh oh!

moylop260 commented Oct 1, 2019

Uh oh!

OCA-git-bot commented Oct 1, 2019

Uh oh!

OCA-git-bot commented Oct 1, 2019

Uh oh!

moylop260 commented Oct 12, 2019

Uh oh!

OCA-git-bot commented Oct 12, 2019

Uh oh!

OCA-git-bot commented Oct 12, 2019

Uh oh!

eilst commented Nov 8, 2019

Uh oh!

OCA-git-bot commented Nov 8, 2019

Uh oh!

moylop260 commented Nov 28, 2019

Uh oh!

moylop260 commented Nov 29, 2019

Uh oh!

OCA-git-bot commented Nov 29, 2019

Uh oh!

OCA-git-bot commented Nov 29, 2019

Uh oh!

OCA-git-bot commented Nov 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants