[MIG][10.0] product_multi_image by lasley · Pull Request #201 · OCA/product-attribute

lasley · 2016-11-10T20:33:45Z

This is WIP & served to rule out old API wire crossing as the 9.0 upgrade issue in #199. We're getting the same effect here, so that's not the case.

I'll fix this PR up once the issue is figured out in the 9.0 version.

Depends:

pedrobaeza · 2016-11-15T08:02:10Z

You can rebase now

lasley · 2016-11-15T17:22:34Z

Rebased. I don't think it made any difference though? I'm still fixing the variant removal issue noted in #199

lasley · 2016-11-30T02:57:47Z

This is solved in OCA/server-tools#629 & should be ready for review after merge

pedrobaeza · 2016-11-30T07:10:56Z

oca_dependencies.txt

@@ -0,0 +1 @@
+server-tools https://github.com/laslabs/server-tools release/10.0/base_multi_image


Change this to regular repo

lasley · 2017-01-10T18:20:03Z

Restarted build now that base fix is merged. Hopefully we go 🍏 !

lasley · 2017-01-10T19:08:54Z

Oh crap this is still pending OCA/server-tools#677 - updating issue description

* Upgrade product_multi_image to v9 * Add server-tools to oca_dependencies

lasley · 2017-01-16T17:10:09Z

Alright rebased now the OCA/server-tools#677 is merged. We should hopefully be 🍏 here now.

@pedrobaeza @yajo - you guys mind if I squash your commits into changesets by author?

yajo · 2017-01-17T08:18:11Z

No problem on my side. Still ❌ though.

pedrobaeza · 2017-01-17T08:25:33Z

Yes, please squash, and check Travis status.

lasley · 2017-01-21T02:44:30Z

Ok so it seems the registry does not operate the same way that we expect it to in the hooks. I totally remember now why I went down the path of making an environment in my server-tools PR. It's wanting a BaseModel instance passed into the search call, but the model being returned from the registry here is a MetaModel.

I'm submitting a new PR for the base & linked this PR against it. We will use this one to determine that my fix actually worked. Don't merge this PR until I switch back 😉

Edit - the MetaModel linked to Travis, which overwrote when I rebuilt - sorry!

yajo · 2017-01-23T09:23:30Z

OK so now it's 💚, but... are we allowed to merge it like this?

pedrobaeza · 2017-01-23T09:24:25Z

What are you referring to?

yajo · 2017-01-23T09:27:29Z

oca_dependencies.txt

@@ -0,0 +1 @@
+server-tools https://github.com/laslabs/server-tools bugfix/10.0/base_multi_image-hook-revisited


@pedrobaeza I'm talking about this.

Ah, OK. No, then we should wait for the merge on the server-tools repo.

Yeah please don't merge yet. I'm just using this as proof that my patch in server-tools actually works this time. I didn't do it last time & now we're in this situation. Sorry, I should have been more clear in my comment.

lasley · 2017-01-23T18:36:24Z

Alright at long last, these tests should pass!

Well, except for the fact that they won't pass due to OCA/maintainer-quality-tools#427 😆

* Migrate product_multi_image to v10 * Remove old api from `product.product` * Add test coverage for hooks and variant count * Fix oca depends * Add uninstall hook

lasley · 2017-01-23T18:44:10Z

Hrm no idea how tests are actually passing with the missing headers, but I'll take it!

lasley · 2017-01-27T20:51:57Z

Without futher ado, I present a 🍏 build - using the production server-tools! Ready for review 🎸

Btw nobody rebuild Travis or it'll go 🔴 on unrelated issue in odoo/odoo. Delicate tip-toe, this passing CI is.

pedrobaeza

Please include also #229

lasley · 2017-02-11T15:40:17Z

Added

lasley · 2017-03-02T16:21:04Z

@tedsalmon please review

angelmoya · 2017-03-20T15:41:23Z

Checked on local environment and works nice!
👍

pedrobaeza · 2017-03-20T15:45:08Z

@lasley have you checked if in uninstallation product images are restored?

angelmoya · 2017-03-20T15:48:08Z

@pedrobaeza @lasley Just I try to uninstall and it fail

File "/opt/odoo/sources/odoo/odoo/modules/loading.py", line 389, in load_modules
getattr(py_module, uninstall_hook)(cr, registry)
AttributeError: 'module' object has no attribute 'uninstall_hook'

pedrobaeza · 2017-03-20T15:51:48Z

hehe, that why I was asking. It seems anyway something easy to fix.

lasley · 2017-03-20T16:29:09Z

Hahahah this is the PR that just keeps on giving- I'll fix it up, thanks for the catch guys!

lasley · 2017-03-28T17:52:01Z

@pedrobaeza @angelmoya - I added the import to the uninstall hook into the init file, which cleared up the uninstall issue in local.

pedrobaeza · 2017-04-01T15:34:31Z

product_multi_image/hooks.py

+def uninstall_hook(cr, registry):
+    """Remove multi images for models that no longer use them."""
+    uninstall_hook_for_submodules(cr, registry, "product.template")
+    uninstall_hook_for_submodules(cr, registry, "product.product")


You still need to restore main image for products/templates here, before calling the base_multi_image hook, or you will lose them on uninstallation.

Ah yes good call. Any idea how we would go about that with the DB modifications still in place? The fields in the product will still be overridden as related, so any changes made to those will simply update the underlying image record instead of the binary field.

My best bet would be to create the column in SQL, and copy data to this column also in SQL. ORM wouldn't interfere in that, and when the field definition with the compute dissapears, Odoo will look again to this column for getting the image.

thomaspaulb · 2018-10-01T09:10:01Z

@pedrobaeza Since this was superseded by #359, can you close this?

pedrobaeza · 2018-10-01T09:17:19Z

Yeah, closing.

…irm website sale order (OCA#201) * [FIX] product_pack: Do not reset packs components when confirm sale order. If a sale order is updated from the website whrn confirm the order we do not expand the pack, we usit as it is. * [ADD] product_pack: Allow modify pack from backend/website Now we can choose if the product can be modified in the only int he backend or if can be modified also in the frontend by the customers. * [FIX] lint

lasley mentioned this pull request Nov 10, 2016

[MIG][9.0] product_multi_image to v9 #199

Merged

1 task

lasley force-pushed the release/10.0/SMD-216-product_multi_image branch 2 times, most recently from dd16b90 to ed5884d Compare November 15, 2016 17:18

pedrobaeza reviewed Nov 30, 2016

View reviewed changes

lasley force-pushed the release/10.0/SMD-216-product_multi_image branch from bc8fef9 to 3af98db Compare November 30, 2016 23:10

lasley mentioned this pull request Dec 26, 2016

[FIX] base_multi_image: Use env in uninstall_hook OCA/server-tools#677

Merged

lasley force-pushed the release/10.0/SMD-216-product_multi_image branch from 3af98db to bb971d2 Compare January 10, 2017 18:22

pedrobaeza and others added 10 commits January 16, 2017 09:08

product_multi_image: Module totally redone from old product_images

9dd6d7a

product_multi_image: PEP8

979a11e

Split model in abstract & concrete.

6ec7aef

Better icon.

fbe73ae

Fix bugs found in review time, improve README.

02e6be1

product_multi_image: Handle images in variants

eea499f

product_multi_image: Deal with product variant removal

a0a3a0e

product_multi_image: Don't crash when base_multi_image is not present

976a6fe

product_multi_image: PEP8

09255d1

[MIG] product_multi_image: Upgrade to v9

1d102e7

* Upgrade product_multi_image to v9 * Add server-tools to oca_dependencies

lasley force-pushed the release/10.0/SMD-216-product_multi_image branch 2 times, most recently from 1ab7984 to 871f110 Compare January 16, 2017 17:09

lasley force-pushed the release/10.0/SMD-216-product_multi_image branch from b2be042 to 5e229c2 Compare January 21, 2017 02:32

lasley force-pushed the release/10.0/SMD-216-product_multi_image branch from 5e229c2 to a57258a Compare January 22, 2017 01:24

yajo reviewed Jan 23, 2017

View reviewed changes

lasley force-pushed the release/10.0/SMD-216-product_multi_image branch from a57258a to 871f110 Compare January 23, 2017 18:31

[MIG] product_multi_image: Upgrade to v10

57958f5

* Migrate product_multi_image to v10 * Remove old api from `product.product` * Add test coverage for hooks and variant count * Fix oca depends * Add uninstall hook

lasley force-pushed the release/10.0/SMD-216-product_multi_image branch from 871f110 to 57958f5 Compare January 23, 2017 18:36

pedrobaeza approved these changes Feb 11, 2017

View reviewed changes

[fix] prod image update broken w/ no image on template OCA#228

0fbdbc4

Add import to uninstall hook

bffada6

pedrobaeza requested changes Apr 1, 2017

View reviewed changes

alexis-via mentioned this pull request Mar 28, 2018

[10.0] Migrate product_categ_image #343

Closed

FFernandez-PlanetaTIC mentioned this pull request Jun 13, 2018

[10.0] [MIG] product_multi_image (supersede) #359

Closed

pedrobaeza closed this Oct 1, 2018

		@@ -0,0 +1 @@
		server-tools https://github.com/laslabs/server-tools release/10.0/base_multi_image

Uh oh!

Conversation

lasley commented Nov 10, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedrobaeza commented Nov 15, 2016

Uh oh!

lasley commented Nov 15, 2016

Uh oh!

lasley commented Nov 30, 2016

Uh oh!

pedrobaeza Nov 30, 2016

Choose a reason for hiding this comment

Uh oh!

lasley commented Jan 10, 2017

Uh oh!

lasley commented Jan 10, 2017

Uh oh!

lasley commented Jan 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yajo commented Jan 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedrobaeza commented Jan 17, 2017

Uh oh!

lasley commented Jan 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yajo commented Jan 23, 2017

Uh oh!

pedrobaeza commented Jan 23, 2017

Uh oh!

yajo Jan 23, 2017

Choose a reason for hiding this comment

Uh oh!

pedrobaeza Jan 23, 2017

Choose a reason for hiding this comment

Uh oh!

lasley Jan 23, 2017

Choose a reason for hiding this comment

Uh oh!

lasley commented Jan 23, 2017

Uh oh!

lasley commented Jan 23, 2017

Uh oh!

lasley commented Jan 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

lasley commented Feb 11, 2017

Uh oh!

lasley commented Mar 2, 2017

Uh oh!

angelmoya commented Mar 20, 2017

Uh oh!

pedrobaeza commented Mar 20, 2017

Uh oh!

angelmoya commented Mar 20, 2017

Uh oh!

pedrobaeza commented Mar 20, 2017

Uh oh!

lasley commented Mar 20, 2017

Uh oh!

lasley commented Mar 28, 2017

Uh oh!

pedrobaeza Apr 1, 2017

Choose a reason for hiding this comment

Uh oh!

lasley Apr 26, 2017

Choose a reason for hiding this comment

Uh oh!

pedrobaeza Apr 27, 2017

Choose a reason for hiding this comment

Uh oh!

thomaspaulb commented Oct 1, 2018

Uh oh!

pedrobaeza commented Oct 1, 2018

lasley commented Nov 10, 2016 •

edited

Loading

lasley commented Jan 16, 2017 •

edited

Loading

yajo commented Jan 17, 2017 •

edited

Loading

lasley commented Jan 21, 2017 •

edited

Loading

lasley commented Jan 27, 2017 •

edited

Loading