I'll get the Travis resolved sometime today

Bah well this error is a real scumbag, and is most definitely legit (good job with your tests @pedrobaeza).

>>> template = self.env['product.template'].create({
        'name': 'Test 2',
        'image_ids': [(0, 0, {
            'storage': 'db',
            'name': 'Image 1',
            'file_db_store': self.transparent_image,
            'owner_model': 'product.template',
        })],
    })
>>> len(template.image_ids)
1
>>> template.write({
        'attribute_line_ids': [
            (0, 0, {
                'attribute_id': self.attribute.id,
                'value_ids': [(6, 0, (self.value_1 + self.value_2).ids)],
            })],
    })
>>> len(template.image_ids)
0

I'm playing around with it in pdb at the moment, just wanted to provide an update because I said this would be done yesterday 😆

@lasley yep, I debugged it a couple of days ago and I was stuck here, when you delete the product the override of unlink deletes ALL the images.
I've not that much background on the whole module so after a while a gave up, willing to come back at some point :)
Let me know if I can help w/ further testing.

I can take a look also, but not before the end of this week.

Yeah it seems that the variants aren't getting appended into the base_multi_image.image.product_variant_ids upon initial creation, so I'm thinking the issue is actually in _compute_image_ids.

(Pdb) template.image_ids
base_multi_image.image(517,)
(Pdb) template.image_ids.product_variant_ids
product.product()

I think it may have something to do with the fact that product.template now defines the image fields using new API, but the product.product still uses old. Maybe something with the API wire crossing similar to what is described in odoo/odoo#10799

We can scratch API wire crossing off the list of possible issues, #201 😦

This is solved in OCA/server-tools#628 & should be ready for review after merge

Rebase your branch

Actually only a rebuild is needed (I have launched it)

@pedrobaeza - I added one for the pre_init as well, Coverage was a free/false green there because it's a guaranteed run. We'll see if they pass, I didn't actually run in local TBH 😉

I'm afraid there's no luck.

Even more disconcerting is the fact that Runbot is 🍏

👏 👏 👏

@lasley Please squash your commits and I'll merge.

Squashed up! I'll knock out the v10 in the next few days

yay! thanks @lasley !