[8.0][product_multi_image] Multi images for products#135
[8.0][product_multi_image] Multi images for products#135pedrobaeza merged 6 commits intoOCA:8.0from yajo:multi_image
Conversation
|
When I install the module product images are "losed"... |
|
Functional test in local 👍 |
| This module implements the possibility to have multiple images for a product, | ||
| that it's to say, an image gallery. | ||
|
|
||
| Usage |
There was a problem hiding this comment.
Add Installation section talking about the dependency to the base module and in which repo it is.
|
For the icon, maybe you can add a symbol/object to represent the product for distinguishing from the base module. |
|
@yajo i could not force rebuild runbot to test |
|
All of the above fixed and/or documented. But this will ❌ until OCA/server-tools#385 is merged. It's a little patch, go there before please 😊 |
yajo
changed the title
|
OCA/server-tools#385 merged. Let's see if you lose no more images, @carlos-incaser. 😉 |
|
👍 code reviewed |
|
👍 |
|
@yajo , Thanks for your work with this module. I'd like to check what the OCA's policy is on including OCA modules as dependencies in paid themes. The website_multi_image module seems like it would be a vital component of most themes currently available for Odoo. Many have their own versions of website_multi_image included within the theme itself, however I think @yajo's module handles this far better, and I believe it will quickly become the de-facto standard (for 8.0/9.0/Master). I'm not interested in starting another endless licensing debate, i'm just curious to know what the OCA's policy is given the situation i've just described so that I can plan ahead and decide whether to include the multi-image module as a direct dependency or if I should declare it as 'compatible with' Yajo's modules. My apologies for diverting from the topic of this issue thread. If there is a more appropriate place to ask this question I will remove this comment and ask wherever you suggest. |
|
@lukebranch, indeed this is not the right place for this discussion, but in sort, you can't. If you derive from an AGPL module, you have to be AGPL too. |
|
Thanks for the confirmation. |
|
Hi @lukebranch, of course you can as long as your license is compatible with AGPL. And you are allowed to ask for money for your themes. |
|
@yajo , Thanks for the confirmation, I look forward to testing the module in production soon and a few themes i'm working on. By the way, for website_multi_image i've just come across a new GPU-accelerated slider that looks quite promising and is much more actively maintained than OwlCarousel here: I haven't looked into it in detail yet, however it looks like it could work quite well for this purpose. |
[8.0][product_multi_image] Multi images for products
6 participants
This will be WIP until OCA/server-tools#374 gets merged.
Implements image gallery for products. Most logic is handled by
base_multi_image.@rafaelbn