Skip to content

[8.0][ADD][website_event_multi_image] Public image gallery in events#33

Closed
yajo wants to merge 4 commits intoOCA:8.0from
yajo:multi-image-website
Closed

[8.0][ADD][website_event_multi_image] Public image gallery in events#33
yajo wants to merge 4 commits intoOCA:8.0from
yajo:multi-image-website

Conversation

@yajo
Copy link
Copy Markdown
Member

@yajo yajo commented Feb 4, 2016

This will fail until OCA/server-tools#374
and #31 get merged.

This module takes functionalities from above ones and displays them in
the website part of events.

See readme for more details.

@rafaelbn

@dreispt dreispt added this to the 8.0 milestone Feb 19, 2016
@dreispt
Copy link
Copy Markdown
Member

dreispt commented Feb 19, 2016

Let's wait on the upstream PR.

yajo added 2 commits March 11, 2016 17:19
This will fail until OCA/product-attribute#112
and #31 get merged.

This module takes functionalities from above ones and displays them in
the website part of events.

See readme for more details.
@yajo
Copy link
Copy Markdown
Member Author

yajo commented Mar 11, 2016

Please remove WIP label, upstream modules are merged now.

I rebased to see if I get 💚

@dreispt
Copy link
Copy Markdown
Member

dreispt commented Mar 11, 2016

👍

@pedrobaeza
Copy link
Copy Markdown
Member

I have tried the module in runbot, and I have some comments:

  • Image gallery appears on the bottom of the event. It makes that you need to scroll all the event description to see the image gallery. Can it appear at the top? Or maybe on the side?
  • I have added some small images and non-squared images:

seleccion_004

In the website image gallery, they appear cropped and very big:

image gallery

Is there the possibility to have another layout?

  • Another useful snippet/template is to have the usual small layout previewing all the images that you expand in the big box when clicking on it. Is it very complicated to implement on website_multi_image?

@andhit-r
Copy link
Copy Markdown
Member

andhit-r commented Apr 1, 2016

Tested on runbot 👍 . @pedrobaeza layout idea is nice to have though. But for now i'm good with current layout. Just put it on top of the page, bellow sales table

@yajo
Copy link
Copy Markdown
Member Author

yajo commented Apr 1, 2016

Hi @pedrobaeza:

Image gallery appears on the bottom of the event. It makes that you need to scroll all the event description to see the image gallery. Can it appear at the top? Or maybe on the side?

Fixed.

I have added some small images and non-squared images:
In the website image gallery, they appear cropped and very big:

This is by design. Image galleries are mostly designed for big-size high-quality pics. They are autocropped to achieve a consistent layout, and to avoid forcing the user to set a specific image size.

This is done by website_multi_image, and you can change behavior with themes if your specific website desires to display icons in the event slideshow.

Another useful snippet/template is to have the usual small layout previewing all the images that you expand in the big box when clicking on it. Is it very complicated to implement on website_multi_image?

This comes out of the box in Odoo 9, so it will be much easier there. I prefer to wait for migrating to target that.

@pedrobaeza
Copy link
Copy Markdown
Member

OK, then 👍

@rafaelbn
Copy link
Copy Markdown
Member

rafaelbn commented Apr 1, 2016

Travis fails

@rafaelbn
Copy link
Copy Markdown
Member

cc @antespi

@rafaelbn
Copy link
Copy Markdown
Member

Please @yajo check travis. Fixing travis we can merge this. Thanks

cc @pedrobaeza

@rafaelbn
Copy link
Copy Markdown
Member

As said, functionally 👍 but check travis before merging

@dreispt
Copy link
Copy Markdown
Member

dreispt commented May 11, 2016

There is a problem from the openerp.addons.website.tests.test_crawl test...

@yajo
Copy link
Copy Markdown
Member Author

yajo commented May 25, 2016

Thanks @dreispt, it seems a permissions issue. I have to add an ACL that allows public users to read images from published events. Does anybody know how to do such thing? I think it is better than adding .sudo() to the controller.

@dreispt
Copy link
Copy Markdown
Member

dreispt commented May 25, 2016

Maybe @hbrunn can suggest something.

@hbrunn
Copy link
Copy Markdown
Member

hbrunn commented May 25, 2016

the ACL seems the way to go. And probably an ir.rule to restrict the public user to indeed only read published images

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 2, 2016

Coverage Status

Coverage decreased (-0.5%) to 87.863% when pulling 49ab4f6 on Yajo:multi-image-website into e55862b on OCA:8.0.

@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 12, 2021
@github-actions github-actions bot closed this Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs fixing needs review stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants