[MIG][15.0] connector + component_event + test_connector by i-vyshnevska · Pull Request #425 · OCA/connector

i-vyshnevska · 2021-12-02T13:45:57Z

No description provided.

simahawk · 2021-12-02T15:02:51Z

test_connector should be migrated too

component_event/tests/test_event.py

i-vyshnevska · 2021-12-06T08:17:06Z

@simahawk ready for review

connector/components/synchronizer.py

yankinmax · 2021-12-06T09:49:51Z

component_event/tests/test_event.py

@@ -162,7 +139,7 @@ class TestEvent(ComponentRegistryCase):

    def setUp(self):
        super(TestEvent, self).setUp()


Suggested change

super(TestEvent, self).setUp()

super().setUp()

yankinmax · 2021-12-06T09:50:19Z

component_event/tests/test_event.py

@@ -392,6 +369,7 @@ class TestEventFromModel(TransactionComponentRegistryCase):

    def setUp(self):
        super(TestEventFromModel, self).setUp()


Suggested change

super(TestEventFromModel, self).setUp()

super().setUp()

yankinmax · 2021-12-06T09:52:08Z

component_event/tests/test_event.py

+    def __init__(self, *args, **kwargs):
+        super().__init__(*args, **kwargs)
+        self.test_sequence = 0


I didn't meet such code before. Could you pls explain what self.test_sequence = 0 is for?

@i-vyshnevska ?

the field is defined in odoo metatest class
https://github.com/odoo/odoo/blob/5cfce06bf92cc746b4dc3b2b554ad57daac1af1d/odoo/tests/common.py#L296
but us we inherit here form uittetst we also need this field so odoo will be able to run test

@i-vyshnevska thanks for the explanation

saxomanu · 2022-01-11T14:42:29Z

Is it ready to merge ? what is missing ? Can i help ?

i-vyshnevska · 2022-01-11T14:47:39Z

@simahawk can you pass another review

connector/components/synchronizer.py

simahawk · 2022-01-11T16:51:47Z

component_event/tests/test_event.py

+    def __init__(self, *args, **kwargs):
+        super().__init__(*args, **kwargs)
+        self.test_sequence = 0


@i-vyshnevska ?

simahawk · 2022-01-11T16:53:10Z

@i-vyshnevska pls squash when done

simahawk

@i-vyshnevska there's a mistake.
There's a commit to migrate "test_connector" but I don't see "test_component".
Also that commit contains unrelated changes 1e0c578
We need test_component here. Plus, I wonder how tests for test_connector

simahawk

Ah, my bad, I got confused by names. Re-checked 15.0, LG.

simahawk · 2022-01-25T06:13:16Z

/ocabot migration connector
/ocabot migration test_connector
/ocabot migration component_event

simahawk · 2022-01-25T06:13:40Z

/ocabot merge nobump

OCA-git-bot · 2022-01-25T06:13:45Z

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-425-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot · 2022-01-25T06:19:03Z

Congratulations, your PR was merged at 5b37cb7. Thanks a lot for contributing to OCA. ❤️

i-vyshnevska force-pushed the 15.0_mig_connector branch 5 times, most recently from 6712d19 to 4cddca9 Compare December 2, 2021 15:00

simahawk requested changes Dec 2, 2021

View reviewed changes

component_event/tests/test_event.py Outdated Show resolved Hide resolved

i-vyshnevska force-pushed the 15.0_mig_connector branch 4 times, most recently from 140e13d to 15a87af Compare December 3, 2021 12:58

i-vyshnevska changed the title ~~[MIG][15.0] connector + connector_event~~ [MIG][15.0] connector + component_event Dec 5, 2021

i-vyshnevska mentioned this pull request Dec 6, 2021

[MIG][15.0] edi_storage_oca OCA/edi#491

Merged

3 tasks

yankinmax reviewed Dec 6, 2021

View reviewed changes

connector/components/synchronizer.py Outdated Show resolved Hide resolved

yankinmax reviewed Dec 6, 2021

View reviewed changes

simahawk mentioned this pull request Dec 20, 2021

Migration to version 15.0 #418

Closed

6 tasks

simahawk reviewed Jan 11, 2022

View reviewed changes

i-vyshnevska force-pushed the 15.0_mig_connector branch from b343f35 to 33e7077 Compare January 12, 2022 07:42

i-vyshnevska added 3 commits January 12, 2022 09:47

[MIG][15.0] component_event

60d27de

[MIG][15.0] component

a85c152

[MIG][15.0] test_connector

1e0c578

i-vyshnevska force-pushed the 15.0_mig_connector branch from 33e7077 to 1e0c578 Compare January 12, 2022 07:48

gurneyalex approved these changes Jan 24, 2022

View reviewed changes

simahawk approved these changes Jan 25, 2022

View reviewed changes

OCA-git-bot added the approved label Jan 25, 2022

simahawk changed the title ~~[MIG][15.0] connector + component_event~~ [MIG][15.0] component + component_event Jan 25, 2022

simahawk requested changes Jan 25, 2022

View reviewed changes

OCA-git-bot removed the approved label Jan 25, 2022

simahawk approved these changes Jan 25, 2022

View reviewed changes

OCA-git-bot added the approved label Jan 25, 2022

simahawk changed the title ~~[MIG][15.0] component + component_event~~ [MIG][15.0] connector + component_event + test_connector Jan 25, 2022

OCA-git-bot added this to the 15.0 milestone Jan 25, 2022

OCA-git-bot added the bot is merging ⏳ label Jan 25, 2022

simahawk mentioned this pull request Jan 25, 2022

[MIG][15.0] edi_oca OCA/edi#490

Closed

1 task

OCA-git-bot merged commit 05aa216 into OCA:15.0 Jan 25, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 25, 2022

		@@ -162,7 +139,7 @@ class TestEvent(ComponentRegistryCase):

		def setUp(self):
		super(TestEvent, self).setUp()

		@@ -392,6 +369,7 @@ class TestEventFromModel(TransactionComponentRegistryCase):

		def setUp(self):
		super(TestEventFromModel, self).setUp()

Uh oh!

Conversation

i-vyshnevska commented Dec 2, 2021

Uh oh!

simahawk commented Dec 2, 2021

Uh oh!

Uh oh!

i-vyshnevska commented Dec 6, 2021

Uh oh!

Uh oh!

yankinmax Dec 6, 2021

Choose a reason for hiding this comment

Uh oh!

yankinmax Dec 6, 2021

Choose a reason for hiding this comment

Uh oh!

yankinmax Dec 6, 2021

Choose a reason for hiding this comment

Uh oh!

simahawk Jan 11, 2022

Choose a reason for hiding this comment

Uh oh!

i-vyshnevska Jan 12, 2022

Choose a reason for hiding this comment

Uh oh!

yankinmax Jan 24, 2022

Choose a reason for hiding this comment

Uh oh!

saxomanu commented Jan 11, 2022

Uh oh!

i-vyshnevska commented Jan 11, 2022

Uh oh!

Uh oh!

simahawk Jan 11, 2022

Choose a reason for hiding this comment

Uh oh!

simahawk commented Jan 11, 2022

Uh oh!

simahawk left a comment

Choose a reason for hiding this comment

Uh oh!

simahawk left a comment

Choose a reason for hiding this comment

Uh oh!

simahawk commented Jan 25, 2022

Uh oh!

simahawk commented Jan 25, 2022

Uh oh!

OCA-git-bot commented Jan 25, 2022

Uh oh!

OCA-git-bot commented Jan 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants