[18.0][FIX] partner_statement: fix account_type comparison in report titles#1470
Merged
OCA-git-bot merged 1 commit intoOCA:18.0from Mar 11, 2026
Merged
Conversation
The wizard sends "asset_receivable" but _get_title methods compared against the old "receivable" value, causing all statements to always show the supplier title variant. Fixes OCA#1465
Contributor
|
Hi @MiquelRForgeFlow, |
MiquelRForgeFlow
approved these changes
Mar 11, 2026
This was referenced Mar 11, 2026
Contributor
|
/ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at f9f173c. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
_get_titlemethods inoutstanding_statement.py,activity_statement.py, anddetailed_activity_statement.pycompareaccount_typeagainst"receivable", but the wizard (statement_common.py) sends"asset_receivable"via a Selection field.This mismatch causes all partner statements to always display the supplier title variant, regardless of the selected account type.
Changes
"receivable"to"asset_receivable"outstanding_statement.py(line 19)activity_statement.py(lines 23, 38)detailed_activity_statement.py(lines 21, 31)Fixes #1465