Conversation
Contributor
|
Hi Sebastian -- congrats again on the paper! I was able to reproduce results, and just merged into main. Thank you for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the SiteRM model from our NeurIPS 2024 paper Ultrafast classical phylogenetic method beats large protein language models on variant effect prediction . SiteRM is an independent-sites model which relies only on MSA information (like EVMutation) and yet does remarkably well.
SiteRM scores both the DMS zero shot substitutions and the clinical zero shot substitutions datasets. The results are as follows:
DMS zero shot substitutions
Clinical zero shot substitutions
Reproducing results
To reproduce the results above, just make sure to
pip install cherryml. Then you can follow the standard pipeline, e.g. for DMS zero shot substitutions:The model will be trained on the spot when running the script
scoring_SiteRM_substitutions.sh. It takes ~2 hours to run on my Mac. The number of cores used to parallelize computation can be changed in the scriptscoring_SiteRM_substitutions.sh(the default is 8). The results reproduce to within +-0.001 for all metrics owing to random seed initialization.Thanks for this great benchmarking resource!
Best,
Sebastian Prillo