Repository navigation
Sync upstream T3 Code 86534db4 (comment prune #19559) - #153
Merged
Merged
Conversation
Exceptional checkpoint: upstream pingdotgg#19559 prunes narration and history comments across 3139 files and adds the no-low-value-comments lint rule. - Upstream's comment cuts and rewrites applied to the fork's code; code tokens match the fork except formatter-only commas/parens and the rule registration. - Rule registered as lecturn/no-low-value-comments (error) with tests; fork-only comments that it flags rewritten or removed. - Rewritten comments use Lecturn names; fork counterparts of T3-named files pruned by hand. - RESOLUTION_GUIDE records the comment policy and kept fork wording. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…ents The mechanical prune left lines the fork had renamed from upstream comment blocks that upstream deleted. Remove those fragments and renamed survivors, restore five fork-only why-comments, finish two cut-off sentences and update the resolution guide. Comment-only: code tokens unchanged. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream sync checkpoint (exceptional): merges T3 Code
86534db4(pingdotgg#19559, "prune narration and history comments") into Lecturn as a true merge (parents7cb85ff1fork main +86534db4). Upstream baseba358222.What changes
lecturn/no-low-value-comments(error, upstream'sno-low-value-commentsunder the fork plugin prefix) with a small test; 4 fork-only section-divider comments it flagged were rewritten or removed.lecturnCLI, Lecturn home/window,@lecturn/*,lecturn.json); fork counterparts of upstream's T3-named files pruned by hand.RESOLUTION_GUIDE.md: comment policy and the kept fork wording.Conflicts
609 (602 content, 6 deleted-by-fork renamed files, 1 added-in-renamed-dir); 514 resolved by a hunk-level comment-only resolver, the rest by area builders (server 35, clients 28, packages 33).
Checks so far
vp lintrepo-wide rc 0;vp fmt --checkon all 3122 changed files.Review
Known limits
apps/mobile/src/features/agent-awareness/remoteRegistration.ts); they are lint-clean and comment-only.🤖 Generated with Claude Code