Repository navigation
upstream(sync): huddle agent prompt — spoken pickup rules (#5863) - #299
Merged
Merged
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Author
CI failure triage + desktop E2E regression pass (Devin)CI triage — the failing E2E jobs are pre-existing on the shared base, not from this PR.
Local desktop E2E regression pass (headless, E2E mock bridge)
App rendered on this branch (E2E mock bridge), huddle trigger visible in the channel header: |
Author
NOTES (handover)DONE
IN PROGRESS
TODO / NEXT
|
Port block#5863 (via block#5671 prompt base) into voice_mode_guidelines: only buzz messages send is spoken, spoken pickup must be the FIRST tool call, no-bare-ack rule explicitly overridden for huddles, follow-up speech bounded. Pin the invariants in the desktop prompt test and add a buzz-acp guard that the text-channel no-bare-ack rule stays intact. Fixes #276 Signed-off-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-Authored-By: Oscar Le <[email protected]>
cursor
Bot
force-pushed
the
devin/issue-276-huddle-spoken-pickup
branch
from
August 23, 2026 03:59
372077b to
30e17b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports upstream block#5863 ("Clarify immediate spoken huddle replies") into the Crew fork as part of the 0.5.18 sync stack (#285): the huddle
voice_mode_guidelinesprompt now pins the spoken-pickup invariants —buzz messages sendto the huddle channel is spoken aloud; everything else is silentAfter this port,
desktop/src-tauri/src/huddle/agents.rsis byte-identical to upstreamdesktop-v0.5.18(verified withgit diff desktop-v0.5.18 -- <file>→ empty).Divergence from the issue's plan (deliberate): issue #276's conflict matrix targets
crates/buzz-acp/src/base_prompt.md+ buzz-acp prompt tests, but upstream block#5863 does not touchbase_prompt.mdat all — its whole diff isvoice_mode_guidelines()(prompt string + doc comment + invariant test) indesktop/src-tauri/src/huddle/agents.rs. This PR ports that actual upstream diff. Notes:HEAD..desktop-v0.5.18delta for this file is exactly the prompt + test, so porting the end-state stays inside upstream(sync): Huddle agent prompt — spoken pickup rules (#5863) #276's scope and does not overlap with upstream(sync): Huddle perf — CPU churn, TTS latency, speech boundaries (#5825, #5671, #6397) #275's perf machinery.base_prompt.mdis untouched; the text-channel "Never publish a bare acknowledgement" rule is unchanged, and a new buzz-acp guard test (shared_base_prompt_keeps_text_channel_no_bare_acknowledgement_rule) pins it — this is the issue's Phase 3 regression test.AGENT-WORKING-AGREEMENT.md: no edit needed — it contains no bare-ack rule to carve a voice exception into; the huddle prompt itself states the override.Related issue
Fixes #276 (part of meta #285; upstream PR block#5863)
Testing
TDD, RED → GREEN (full logs attached to the session):
voice_mode_guidelines_pin_spoken_reply_as_first_tool_calltest first — failed on old prompt (left: 18, right: 6line count).cargo test --manifest-path desktop/src-tauri/Cargo.toml --lib huddle::agents::tests→ 2 passed / 0 failed.Gates run locally (all on this branch):
pnpm --filter buzz checkpnpm --filter buzz typecheckpnpm --filter buzz testjust test-unitbuzz-cli(3: command-inventory-stability) andbuzz-db(1: migration count) — verified identical failures onmain, pre-existing and unrelated to this diff; all other suites passcargo test -p buzz-acp --libcargo test --manifest-path desktop/src-tauri/Cargo.toml --libjust check-compileNo UI-visible change (Rust prompt string consumed by agents), so evidence is terminal logs rather than screenshots.
NOTES (handover)
DONE
voice_mode_guidelines()prompt + doc comment + invariant test indesktop/src-tauri/src/huddle/agents.rs; file is byte-identical to upstreamdesktop-v0.5.18.shared_base_prompt_keeps_text_channel_no_bare_acknowledgement_ruleincrates/buzz-acp/src/lib.rs(text-channel no-bare-ack rule stays intact;base_prompt.mduntouched — deliberate divergence from the issue plan, see Summary above).pnpm --filter buzz check/typecheckpass;pnpm --filter buzz test5528 passed;cargo test -p buzz-acp --lib1023 passed; tauri lib 2694 passed;just check-compilepass;just test-unitfails only in buzz-cli (3) + buzz-db (1), verified identical onmain(pre-existing).origin/maincontrol run (pre-existing). All 30 huddle-transcription tests + channels huddle header tests passed.main(parent's merge commit 372077b fast-forwarded locally).IN PROGRESS
.agents/skills/desktop-e2e-observation/SKILL.mdupdate (delivered as a separate skill-PR suggestion in the requester's timeline) and a non-functional test-plan scratch file.TODO / NEXT
huddle/agents.rs+buzz-acp/lib.rs; sibling issues touch other areas — upstream(sync): Huddle perf — CPU churn, TTS latency, speech boundaries (#5825, #5671, #6397) #275 perf machinery is the nearest neighbor but doesn't overlap this file's delta).main(wholeproject-pr-reviewsuite broken;channel-muteopacity assertion 0.5 vs 0.45).Link to Devin session: https://app.devin.ai/sessions/4b0883acec13436cbc057908d8e3111b
Requested by: @oscarlehuu