Repository navigation
refactor(prompt): compose upstream #6340 agent guidance - #296
Conversation
Port Buzz block#6340 into the Crew base prompt: compact the Conversational Agent Creation section to two paragraphs and clarify that omitting channels create --ttl yields a permanent channel. Crew office sections (CoS intake, evidence-on-completion, Gate C, no-bare-ack) stay in place after upstream Communication Patterns, guarded by new contract tests. Signed-off-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-Authored-By: Oscar Le <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Runtime verification — composed base prompt actually reaches a live ACP agentTested with the ACP v2:
|
Summary
Ports upstream Buzz block#6340 (
refactor(prompt): simplify Buzz agent guidance, commit752efe669) into the Crew fork, composed rather than applied blindly.base_prompt.md— the## Conversational Agent Creationsection collapses from four blocks (two prose paragraphs + a bare command line + a draft-update note) into upstream's two paragraphs:Everything removed here is upstream text — no Crew delta is lost. All Crew office sections (CoS intake, Evidence on completion, Gate C client acceptance, no-bare-ack, call-by-name) keep their position after upstream's
## Communication Patterns, perdocs/crew/UPSTREAM-SYNC.md; the CrewBUZZ_AUTH_TAGdraft caveat stays in the Buzz CLI section.buzz-cli— upstream'schannels create --ttlhelp clarification (omitting--ttl⇒ permanent channel) is the second half of the same upstream commit, so it lands here rather than in the sibling CLI issue (#284, which touchesmessages). Doc-comment text only, no behaviour change.Two new prompt-contract tests machine-check both halves of the compose, so a future sync cannot silently re-expand the section or move a Crew section above Communication Patterns.
Divergences from upstream: none required. Upstream's parent revision also contains
buzz issues assign/buzz projects createprompt text that Crew does not carry yet — out of scope for #283, left to its own sync child.Related issue
Fixes #283 (parent sync meta #285, guardrail #278 — no IA files touched).
Testing
TDD, non-UI change → full terminal logs attached to the session message.
RED:
cargo test -p buzz-acp --lib agent_draft_prompt_tests→shared_base_prompt_agent_creation_is_compact_upstream_formFAILED;cargo test -p buzz-cli --lib channels_create_ttl→ FAILED.GREEN:
cargo test -p buzz-acp --lib→ 1024 passed, 0 failed (all pre-existing Crew prompt assertions still green); new prompt tests + CLI ttl test pass.Gates:
pnpm --filter buzz check✅,pnpm --filter buzz typecheck✅,pnpm --filter buzz test✅ (5528 passed / 1 skipped / 0 failed),just check-compile✅,cargo clippy -p buzz-acp -p buzz-cli --all-targets✅ (warnings only, pre-existing).just test-unitreports two failures that are pre-existing onmainand unrelated to this diff (baseline logs captured on a cleanmaintree):buzz-cliinventory tests (command_inventory_is_stable,subcommand_counts_are_stable,subcommand_names_are_stable) — drift from the Crew-addedagents callsubcommand.buzz-dbembedded_migrator_contains_consolidated_initial_schema— migration count 31 vs expected 30.Both fail identically with this branch stashed, so they are not fixed here (out of upstream(sync): Tier 1 ACP prompt compose — Buzz agent guidance (#6340) #283 scope).
Reality ladder: level 0 (prompt text + machine-checked contract). No UI surface changed; the prompt is consumed by the ACP harness, so a fresh-channel agent session pickup (#116) is the level-2 check left for the sync meta.
Link to Devin session: https://app.devin.ai/sessions/0ffe1fa784824cba8eddafe194122337
Requested by: @oscarlehuu