Skip to content

upstream(sync): Guardrail — preserve channel-first IA during 0.5.18 merge #278

Closed

Description

@oscarlehuu

Intent

Meta guardrail for the full desktop-v0.5.18 sync: never restore Buzz Projects rail / Workbench / top-nav Projects while absorbing engine layers.

Decisions: #223, #219, D-065, D-066

Conflict matrix (files that MUST stay Crew-owned on conflict)

File Rule
AppSidebar.tsx, AppSidebarPinnedHeader.tsx No Projects/Workbench nav entries
AppShell.tsx, useAppNavigation.ts, routes.ts Redirect-only /workbench; no onSelectProjects
message-thread-panel-head.tsx Live-job desk only (#219)
ChannelPane.tsx Crew workspace selector + Tool Pane; no upstream Projects toolbar replace

TDD plan

Phase 1 — RED (regression guards)

  • Existing E2E must pass before merge: sidebar contract, workbench redirect specs, workspace-binding-selector
  • Add check-pane-responsive / sidebar snapshot if missing post-merge

Phase 2 — Merge verify

  • On conflict resolution: if hunks add onSelectProjects, Projects sidebar section, or Workbench picker → reject hunks
  • git diff checklist in PR template

Phase 3 — Accept

  • Founder 2-min try: sidebar = Inbox + channels + DMs only
  • Screenshot compare crew-theme-screenshots sidebar shots

Blocks

All Tier 3 child issues (#270–#276). Reviewer uses this checklist on sync PR.

Unresolved

  • Whether to add CI grep guard banning onSelectProjects in sidebar files

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions