Skip to content

Allow Ocenanaigans v0.106#575

Merged
giordano merged 1 commit intomainfrom
mg/oceananigans
Mar 20, 2026
Merged

Allow Ocenanaigans v0.106#575
giordano merged 1 commit intomainfrom
mg/oceananigans

Conversation

@giordano
Copy link
Copy Markdown
Member

Based on the release notes of v0.106 we shouldn't be affect by breaking changes. I guess we'll see how CI goes.

@giordano
Copy link
Copy Markdown
Member Author

Uhm, nothing is actually using Oceananigans v0.106 at the moment, because other packages aren't compatible with it yet.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@navidcy
Copy link
Copy Markdown
Member

navidcy commented Mar 20, 2026

Like which package(s)?

@giordano
Copy link
Copy Markdown
Member Author

I thought we were using NumericalEarth somewhere somewhere, but we aren't. So my next hypothesis is more simply the current PkgServer being stuck at ~12 hours ago:

% curl -LIs https://pkg.julialang.org/registries.eager | grep last-modified
last-modified: Thu, 19 Mar 2026 14:54:22 GMT

@navidcy
Copy link
Copy Markdown
Member

navidcy commented Mar 20, 2026

It's a weak dependency for the extension. Only used in one of the examples.

@giordano giordano closed this Mar 20, 2026
@giordano giordano reopened this Mar 20, 2026
@giordano
Copy link
Copy Markdown
Member Author

Registry is up-to-date now

% curl -LIs https://pkg.julialang.org/registries.eager | grep last-modified
last-modified: Fri, 20 Mar 2026 10:20:49 GMT

and Oceananigans v0.106 is being installed now

Copy link
Copy Markdown

@numterra-bot numterra-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Breeze.jl Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.

Benchmark suite Current: bcd2a6c Previous: b6b71ed Ratio
CBL; Dynamics: anelastic; Microphysics: nothing [Float32]/Compare advections/NVIDIA L4/WENO5 [256, 256, 128] 108730835.14025283 points/s 122393416.30047764 points/s 1.13
CBL; Dynamics: anelastic; Microphysics: nothing [Float32]/Advection: WENO5/NVIDIA L4/256x256x128 108730835.14025283 points/s 122393416.30047764 points/s 1.13

This comment was automatically generated by workflow using github-action-benchmark.

@giordano
Copy link
Copy Markdown
Member Author

⚠️ Performance Alert ⚠️

Sigh 😓 #570 was clearly not enough, but at least the drop is by 13%, not 31% as we used to with the smaller grid 😅

@giordano giordano merged commit fab76dc into main Mar 20, 2026
30 checks passed
@giordano giordano deleted the mg/oceananigans branch March 20, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants