You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit ddd1579
Browse filesBrowse the repository at this point in the historyBrowse files
NriExternalException for EXT_ERROR: a failed third-party call, to fall back on
NRI v192 returns Result::EXT_ERROR when a library it calls fails (an upscaler SDK, Reflex) and the
device stays usable. It now has its own type beside NriDeviceLostException and
NriUnsupportedException, derived from NriException, so a caller catches it by type; the message
still carries the vendor call and code NRI reported. InteropTests holds the mapping, and
UpscalerFailureTests holds NRI's real EXT_ERROR (a missing FSR or DLSS runtime) to it.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01NvXTk6Roe4sQLHFx9Zykv8
|`NriDeviceOptions`| mirrors `DeviceCreationDesc` field for field |
171
171
|`QueueFamilies`| empty means one graphics queue. Request every family up front: NRI trims the device's queue counts to what was created, so `Video` is `UNSUPPORTED` unless `VIDEO_DECODE` / `VIDEO_ENCODE` were requested |
172
-
|`MessageHandler`| receives NRI and validation-layer messages. A throwing handler loses that one message. An `NriException` (and `NriDeviceLostException`, `NriUnsupportedException`) carries the last error text reported on its own thread since the binding last checked a result there: the failing call's own, or that of a refused `Cmd*` before it (those return nothing, so nothing checks them); never another thread's, and none when nothing was reported; `device.LastError` holds the device's last error text, from any thread. A Khronos layer message arrives as `[id] name: text` (patch 0015 adds the name, e.g. `BestPractices-vkBindImageMemory-small-dedicated-allocation`; upstream forwards the number and the text, and current layers no longer embed the name in the text) |
172
+
|`MessageHandler`| receives NRI and validation-layer messages. A throwing handler loses that one message. An `NriException` (and `NriDeviceLostException`, `NriUnsupportedException`, `NriExternalException`) carries the last error text reported on its own thread since the binding last checked a result there: the failing call's own, or that of a refused `Cmd*` before it (those return nothing, so nothing checks them); never another thread's, and none when nothing was reported; `device.LastError` holds the device's last error text, from any thread. A Khronos layer message arrives as `[id] name: text` (patch 0015 adds the name, e.g. `BestPractices-vkBindImageMemory-small-dedicated-allocation`; upstream forwards the number and the text, and current layers no longer embed the name in the text) |
173
173
|`BreakOnError`| breaks only when a debugger is attached; otherwise errors never terminate the process. Also decides the D3D12 debug layer's own break (`SetBreakOnSeverity` for ERROR and CORRUPTION), evaluated at device creation: on only with `BreakOnError` and a debugger attached then. Otherwise a D3D12 debug-layer error arrives as an error message, `[id] text`|
174
174
|`EnableD3D12GpuBasedValidation`| D3D12 GPU-based validation: checks descriptors and resource states while shaders run. Slow; needs `EnableGraphicsApiValidation`. Process-global and never switched off: every D3D12 device created later in the process has it |
175
175
|`Allocator`|`INriAllocator` for NRI's own host allocations; `NriCountingAllocator` counts them. It must not fail: a null (a throwing allocator returns one) fails an NRI object's creation with `OUT_OF_MEMORY`, but NRI's containers allocate through it too and crash on one, device creation's first allocation among them |
@@ -741,9 +741,9 @@ if (up.IsUpscalerSupported(UpscalerType.FSR) && up.IsRuntimeInstalled(UpscalerTy
741
741
makes both hosts work. Put the files beside your app's assembly.
742
742
- XeSS: D3D12 only. FSR: D3D12 and Vulkan. NIS: everywhere the Upscalers build runs. DLSR and
743
743
DLRR (a `-WithDlss` build): NVIDIA adapters with ray tracing, both backends.
744
-
- A failed vendor call reports an ERROR through your message handler. A failed creation throws `NriException`
745
-
with `Result.EXT_ERROR` (NRI's result for a third-party failure, which never calls
746
-
`AbortExecution`), or `INVALID_ARGUMENT`, `UNSUPPORTED` or `OUT_OF_MEMORY` when the vendor's code
744
+
- A failed vendor call reports an ERROR through your message handler. A failed creation throws `NriExternalException`
745
+
(`Result.EXT_ERROR`, NRI's result for a third-party failure, which never calls
746
+
`AbortExecution`; catch it to fall back), or `NriUnsupportedException` or an `NriException` with `INVALID_ARGUMENT` or `OUT_OF_MEMORY` when the vendor's code
747
747
says so; never a bare `FAILURE`. A failed dispatch returns nothing (a command). At creation the message
748
748
names the missing FSR loader DLL or the NGX result, at dispatch the vendor call and its result
749
749
(`ffxDispatch`, `xessD3D12Execute`, NGX's evaluation). DLSS may create without its DLL
Copy file name to clipboardExpand all lines: docs/releases/v192.0.0-beta.1.md
+2-1Lines changed: 2 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,10 +1,11 @@
1
1
## Added
2
2
- NRI v192
3
3
-`Nri.BindingVersion`, `Nri.DescsVersion`, `Nri.BindingNriVersion`, `Nri.DescsNriVersion`: the loaded packages' versions, read at run time
4
+
-`NriExternalException`: a failed third-party call (`Result.EXT_ERROR`: an upscaler SDK, NVIDIA Reflex), for falling back
4
5
- D3D12: a refused pipeline cache reports why as an INFO (another driver version, another adapter, not a pipeline library); still `OUT_OF_DATE`
5
6
6
7
## Fixed
7
-
- A failed vendor upscaler creation throws with `EXT_ERROR` (or `INVALID_ARGUMENT`, `UNSUPPORTED`, `OUT_OF_MEMORY` when the vendor's code says so) and reports an ERROR naming the call; a failed dispatch reports one too
8
+
- A failed vendor upscaler creation throws `NriExternalException` (or `NriUnsupportedException`, or `NriException` with `INVALID_ARGUMENT` or `OUT_OF_MEMORY`, when the vendor's code says so) and reports an ERROR naming the call; a failed dispatch reports one too
8
9
- D3D12 device creation with the debug layer: no `[989]``CheckFeatureSupport` warnings
9
10
- D3D12 debug layer: no warnings `[963]`, `[964]`, `[971]` for a pipeline not yet in the cache or a cache from another driver or adapter
10
11
- An application's `ResolvingUnmanagedDll` handler for "NRI" runs whenever it was registered (SharpNRI's own handler threw and ended the chain); a missing NRI library is explained at device creation and adapter enumeration
Console.WriteLine($"FAIL {api}{type}: {result}, expected EXT_ERROR for a missing vendor library{(type==UpscalerType.FSR?"":" or the vendor's mapped result")}");
0 commit comments