Closed
Conversation
There was a problem hiding this comment.
is this a onetime call that is being cached?
Contributor
Author
There was a problem hiding this comment.
This is a one-time call at application startup.
Contributor
Author
|
Think it's done. @xavierdecoster @yishaigalatzer @bhuvak @johnataylor feel free to checkout this branch and perform some testing on the OData endpoints. If okay I'll merge it in and deploy whenever we feel like it. |
There was a problem hiding this comment.
nit: Shouldn't m.MediaType == "application/atomsvc+xml" comparison be also case insensitive? (same as the comparison for StartsWith)
Contributor
Author
There was a problem hiding this comment.
Thanks, good catch!
* Remove null propagation interceptor as OData FX takes care of it * Rewrite SearchAdaptor.GetNextLink invocation to ensure results are not executed twice * Searches that are deflected to the database are now handled by OData framework - no need for manual intervention in these cases
This reverts commit c73ecb0.
maartenba
force-pushed
the
issue-2557
branch
from
fba906a to
350d040
Compare
Contributor
Author
|
Superseded by #2848 - keeping the branch open for a bit though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2557.
@xavierdecoster @yishaigalatzer @bhuvak @johnataylor Feel free to checkout this branch and perform some testing on the OData endpoints. Any bug / issue you find is very welcome!