Exclude Microsoft.Extensions.DependencyInjection.* assemblies from VSIX#7007
Merged
donnie-msft merged 3 commits intodevfrom Dec 17, 2025
Merged
Exclude Microsoft.Extensions.DependencyInjection.* assemblies from VSIX#7007donnie-msft merged 3 commits intodevfrom
donnie-msft merged 3 commits intodevfrom
Conversation
Merged
3 tasks
donnie-msft
changed the title
donnie-msft
changed the title
zivkan
reviewed
Dec 12, 2025
donnie-msft
changed the title
zivkan
approved these changes
Dec 12, 2025
jeffkl
approved these changes
Dec 12, 2025
Nigusu-Allehu
approved these changes
Dec 12, 2025
nkolev92
approved these changes
Dec 15, 2025
donnie-msft
force-pushed
the
dev-donnie-msft-moveVsixInclude
branch
from
69edaf7 to
389a223
Compare
This was referenced Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: engineering
Description
While building, I was sure I got an error that this assembly was missing from the VSIX. However, after it was pointed out in comment #6982 (comment), I tried excluding these assemblies from the VSIX and had no trouble.
Microsoft.Extensions.DependencyInjection.*assemblies listed in our vsixinclude were part of my VS Installation folder's PublicAssemblies. Therefore, I'm moving the following to the.vsixignorewhich should reduce our VSIX size:PR Checklist
Added testsLink to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.