Conversation
ghost
added
the
nkolev92
previously approved these changes
Nov 17, 2023
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition=" '$(TargetFramework)' == '$(NetStandardVersion)' or '$(TargetFramework)' == 'net7.0' or '$(TargetFramework)' == 'net8.0' "> | ||
| <ItemGroup Condition=" '$(TargetFramework)' == '$(NetStandardVersion)' or '$(TargetFramework)' == 'net7.0' or '$(TargetFramework)' == 'net8.0' or '$(TargetFramework)' == 'net9.0' "> |
Member
There was a problem hiding this comment.
We don't really build for all t3 here do we?
Maybe replacement is in order instead of just adding an extra condition?
I don't feel super strongly about fixing though, cause this is more on us as NuGet.Client rather than something you'd need to figure out.
Contributor
There was a problem hiding this comment.
Why not just use "'$(TargetFrameworkIdentifier)' == '.NETCoreApp' or '$(TargetFrameworkIdentifier)' == '.NETStandard'" here and in all the other places instead?
donnie-msft
approved these changes
Nov 17, 2023
jeffkl
approved these changes
Nov 21, 2023
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13018
Regression? Last working version:
Description
For .NET 9, source build is now dependent on a .NET 9 build of the SDK. This causes the build of the NuGet.Client repo to fail because it's still targeting net8.0. These changes update the TFM references to include net9.0.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation