Skip to content

Add disableTLSCertificateValidation property to nuget.config#5504

Merged
Nigusu-Allehu merged 2 commits into
dev-feature-disable-TLS-certificate-verificationfrom
dev-nyenework-disableTLSCertificateValidation
Nov 16, 2023
Merged

Add disableTLSCertificateValidation property to nuget.config#5504
Nigusu-Allehu merged 2 commits into
dev-feature-disable-TLS-certificate-verificationfrom
dev-nyenework-disableTLSCertificateValidation

Conversation

@Nigusu-Allehu

@Nigusu-Allehu Nigusu-Allehu commented Nov 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Bug

Fixes: NuGet/Home#12996

Regression? Last working version:

Description

We need to add a disableTLSCertificateValidation property into packageSources section in NuGet.Config files, as below:

<!-- Disables certification validation on a specific https source -->
<packageSources>
    <add key="Contoso" value="https://contoso.com/packages/" disableTLSCertificateValidation="true" />
</packageSources>

spec : https://github.com/NuGet/Home/blob/dev/proposed/2023/InsecureConnectionsDisableCertificateValidation.md#package-source-nuget-config

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A

  • Documentation

    • Documentation PR or issue filled :
    • OR
    • N/A

@Nigusu-Allehu
Nigusu-Allehu requested a review from a team as a code owner November 11, 2023 00:02
@kartheekp-ms

kartheekp-ms commented Nov 11, 2023

Copy link
Copy Markdown
Contributor

We need to add a disableTLSCertificateVerification property into packageSources section in NuGet.Config files, as below:

Thanks, Nigusu. Are you planning on creating another PR for https://github.com/NuGet/Home/blob/dev/proposed/2023/InsecureConnectionsDisableCertificateValidation.md#technical-explanation?

@kartheekp-ms

kartheekp-ms commented Nov 11, 2023

Copy link
Copy Markdown
Contributor

Documentation PR or issue filled

please add the link to docs issue in this PR description.

@Nigusu-Allehu

Nigusu-Allehu commented Nov 12, 2023

Copy link
Copy Markdown
Member Author

We need to add a disableTLSCertificateVerification property into packageSources section in NuGet.Config files, as below:

Thanks, Nigusu. Are you planning on creating another PR for https://github.com/NuGet/Home/blob/dev/proposed/2023/InsecureConnectionsDisableCertificateValidation.md#technical-explanation?

Thank you Kartheek! Yes, I will create another PR for that.

@Nigusu-Allehu
Nigusu-Allehu force-pushed the dev-nyenework-disableTLSCertificateValidation branch from 5cd96b1 to 60a03ad Compare November 12, 2023 01:56
@nkolev92

nkolev92 commented Nov 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

@Nigusu-Allehu I think the docs link in the PR description is incorrect. It's linking to the technical explanation, not a docs issue for documenting the new property.

@Nigusu-Allehu
Nigusu-Allehu changed the base branch from dev to dev-feature-disable-TLS-certificate-verification November 15, 2023 17:46
@Nigusu-Allehu
Nigusu-Allehu merged commit e3f95c9 into dev-feature-disable-TLS-certificate-verification Nov 16, 2023
@Nigusu-Allehu
Nigusu-Allehu deleted the dev-nyenework-disableTLSCertificateValidation branch November 16, 2023 01:19
@Nigusu-Allehu Nigusu-Allehu mentioned this pull request Mar 8, 2024
Merged
8 tasks
Nigusu-Allehu added a commit that referenced this pull request Mar 8, 2024
@Nigusu-Allehu
Add disableTLSCertificateValidation property to nuget.config (#5504)
ea7fea2
Nigusu-Allehu added a commit that referenced this pull request Mar 8, 2024
@Nigusu-Allehu
Add disableTLSCertificateValidation property to nuget.config (#5504)
6f332d3
Nigusu-Allehu added a commit that referenced this pull request Mar 8, 2024
@Nigusu-Allehu
Add disableTLSCertificateValidation property to nuget.config (#5504)
eeae9df
Nigusu-Allehu added a commit that referenced this pull request Apr 1, 2024
@Nigusu-Allehu
Add disableTLSCertificateValidation property to nuget.config (#5504)
1ac36bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nkolev92 nkolev92 nkolev92 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a disableTLSCertificateVerification property

3 participants

@Nigusu-Allehu @kartheekp-ms @nkolev92