Closed
Conversation
dominoFire
reviewed
Mar 16, 2021
Contributor
dominoFire
left a comment
dominoFire
left a comment
There was a problem hiding this comment.
Thanks for your contribution, @crummel !
I'm working on having a green build for this PR. I left one question.
| <SourceBuildManagedOnly>true</SourceBuildManagedOnly> | ||
| </PropertyGroup> | ||
|
|
||
| <Target Name="ApplySourceBuildPatchFiles" |
Contributor
There was a problem hiding this comment.
I removed some patches for source-build 5.0,
Do I need to remove those patches from dotnet/source-build@release/5.0 branch ?
Contributor
Author
There was a problem hiding this comment.
We will take care of that when we uptake these changes. Thanks!
dominoFire
reviewed
Mar 18, 2021
dominoFire
approved these changes
Mar 18, 2021
Member
Contributor
|
Is this superseded by #4105? If so can it be closed? |
Contributor
Author
|
Where you still planning on merging this @dominoFire? I'm still building off it, or I can roll it into the other PR. |
This was referenced Jun 15, 2021
Contributor
Author
|
Closed, redundant with #4105. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/857
Regression? No. Last working version: N/A
Description
This is the first part of arcade-powered source-build changes. The goal is to enable each repo to be able to build source-build-clean on its own, and be able to aggregate this into a product that is shippable in open-source Linux distributions.
This PR adds the local build infrastructure that lets ArPow (arcade-powered source-build) run in this repo. See https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/onboarding/local-onboarding.md for more details about how it works.
To try it out locally, run this on Linux:
./build.sh -c Release --restore --build --pack /p:ArcadeBuildFromSource=true -blThis PR should have no effect on ordinary builds, or CI. ArPow stage 2 will add source-build to CI: PR validation and official builds.
For https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/implementation-plan.md.
This PR is effectively blocked on NuGet/Home#10646 as we can't test it out without that change.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation