Conversation
zkat
force-pushed
the
dev-feature-readme
branch
from
e9a08fd to
0cf923d
Compare
2 tasks
Contributor
|
@zkat what's the status of this one? |
Member
|
🔔 Can you please update the status here? Given that it is a feature branch merge, I imagine just rebasing and re-runing the tests is required. |
Contributor
Author
|
just rebased it. Fingers crossed that I fixed the conflicts correctly :) |
zkat
requested review from
aortiz-msft,
chrisraygill,
dominoFire,
donnie-msft,
drewgillies,
dtivel,
erdembayar,
heng-liu,
jebriede,
kartheekp-ms,
nkolev92,
rrelyea and
zivkan
chrisraygill
approved these changes
Mar 3, 2021
chrisraygill
left a comment
chrisraygill
left a comment
There was a problem hiding this comment.
LGTM with general suggestion to change README --> Readme
zkat
force-pushed
the
dev-feature-readme
branch
2 times, most recently
from
d1373ed to
8f2e8e5
Compare
* Made basic changes to classes to allow for a Readme element in the nuspec file * More changes for readme functionality * Adding the readme property if 'readme.md' is present in the base directory * Added support for dotnet pack for .csproj files * Added validation for Readmes when packing, brought dotnet pack up to speed with nuget pack * Changed variable names, changed error message for empty Readme * Removed commented code * Added a summary for the CheckForReadme method * Added support for dotnet pack for .csproj files * Added support for dotnet pack for .csproj files * Added validation for Readmes when packing, brought dotnet pack up to speed with nuget pack * Changed variable names, changed error message for empty Readme * Updated PublicAPI.Unshipped.txt files * Changed some spacing * Wrote tests for packing embedded readmes * Removed automatic packing of readmes from base directory * Used platform independent directory separating chars for testing * Update src/NuGet.Core/NuGet.Packaging/PackageCreation/Authoring/ManifestMetadata.cs Co-authored-by: donnie-msft <[email protected]> * Updated PublicAPI files after file structure was modified * Reverted to 'Readme == string.Empty' so that the Readme element remains optional * Removed 1 MB file size check on pack * Updated Public API files * Updated Public API files again, builds fine locally * Fixed a bug with dir. separating chars (which seemed to affect /* searches exclusively?), added some tests to catch it out * Changed var name in one of the tests * Changed tests that were constructed incorrectly for non-Windows platforms * Added dotnet pack tests Co-authored-by: donnie-msft <[email protected]>
* Made initial changes for PM UI work for Readmes * Added ReadmeUrl element to all the relevant places, still using ProjectUrl to see an an actual link for now * URL now shows when user hovers over the link's text * Removed the placeholder URL value that used the ProjectUrl
zkat
force-pushed
the
dev-feature-readme
branch
from
8f2e8e5 to
1919a94
Compare
|
Is readme property mandatory now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges in the main changes for the Readme feature into dev