Do not set NoBuild with GeneratePackageOnBuild because property reuse breaks publish#2822
Merged
Conversation
nkolev92
changed the title
peterhuene
approved these changes
Apr 24, 2019
|
Thanks for the fix and heads-up as there is a change I need to make to the .NET Core SDK targets once we ingest this fix in the SDK. |
Member
Author
|
@peterhuene Do you need this only in 3.0? I assume it's ok to target Preview 6? |
|
Only in 3.0 and preview 6 is fine. |
nkolev92
requested review from
dominoFire,
donnie-msft,
dtivel,
heng-liu and
zivkan
April 24, 2019 21:22
zivkan
approved these changes
Apr 24, 2019
| ProjectFileUtils.WriteXmlToFile(xml, stream); | ||
| } | ||
| // Run and assert. | ||
| msbuildFixture.RunDotnet(workingDirectory, $"publish {projectFile}"); |
Member
There was a problem hiding this comment.
I don't know the msbuildfixture utility. What is it asserting? I guess that the command ran successfully. Can it return the process exit code, so we can write the assert in the test, to make it more obvious to people reading the test?
Member
Author
There was a problem hiding this comment.
It asserts the exit code.
By default it is asserting that it completed successfully.
It also returns a command runner result.
I can add another assert to make it clearer.
This was referenced May 22, 2019
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#7801
Regression: No
Fix
Details:
GeneratePackageOnBuild setting NoBuild prevents basic projects from publishing.
This is a backwards compatible change.
I have added a test to confirm that this actually fixes the aforementioned problem.
We're "technically" testing a different product here, so there's potential that this could be a noisy test (highly unlikely).
//cc @peterhuene
Will merge this when dev switches to 5.2.
Testing/Validation
Tests Added: Yes
Reason for not adding tests:
Validation: