Repository navigation
Conversation
alt-glitch
added
type/bug
An interrupted hermes update after git pull advanced HEAD never restarted running gateways, and the next update said "Already up to date" and skipped the fleet. Persist a HERMES_HOME fleet_restart_pending marker after HEAD moves, clear it only when restart completes (or nothing was running), and catch up on the next hermes update even when git is current — also when latest.json records a stale runtime SHA. Co-authored-by: GokayAI <[email protected]>
cursor
Bot
force-pushed
the
cursor/fix-update-pending-fleet-restart-9c5d
branch
from
August 26, 2026 09:53
6c1cd9a to
9bbcead
Compare
This was referenced Aug 26, 2026
Collaborator
|
Closing — this fix landed on main, merged in the final backend-cluster salvage PR #95980 (merge 00988f3), cherry-picked with your authorship preserved. This delivers parts 1+2 of #95294. Thanks @gokay-ai for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #95294 (parts 1+2)
Interrupted
hermes updateafter a successful pull left the gateway on stale code. The next run said already up to date and skipped the restart.This writes
fleet_restart_pendingafter HEAD advances, clears it when the fleet restart finishes (or there were no services), and still restarts on the nexthermes updateif the marker or a skewedlatest.jsonis there. Plainhermesonly warns.Part 3 is yours. Thanks for the constraints.