fix(auxiliary): validate response shape in call_llm/async_call_llm#7631
Closed
kshitijk4poor wants to merge 1 commit intoNousResearch:mainfrom
Closed
fix(auxiliary): validate response shape in call_llm/async_call_llm#7631kshitijk4poor wants to merge 1 commit intoNousResearch:mainfrom
kshitijk4poor wants to merge 1 commit intoNousResearch:mainfrom
Conversation
…ousResearch#7264) async_call_llm (and call_llm) can return non-OpenAI objects from custom providers or adapter shims, crashing downstream consumers with misleading AttributeError ('str' has no attribute 'choices'). Add _validate_llm_response() that checks the response has the expected .choices[0].message shape before returning. Wraps all return paths in call_llm, async_call_llm, and fallback paths. Fails fast with a clear RuntimeError identifying the task, response type, and a preview of the malformed payload. Closes NousResearch#7264
9 tasks
Contributor
|
Merged via #7647. Your commit was cherry-picked onto current main with your authorship preserved in git log. Thanks @kshitijk4poor! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
async_call_llm()can return non-OpenAI objects (bare strings, dicts, etc.) from custom providers or adapter shims. These propagate to downstream consumers likesession_search_tool.pywhich crashes with a misleadingAttributeError: 'str' object has no attribute 'choices'.Changes
_validate_llm_response()that checks the response has the expected.choices[0].messageshapecall_llm(),async_call_llm(), and payment fallback pathsRuntimeErroridentifying the task, response type, and a preview of the malformed payloadCloses #7264
Part of #7605