Repository navigation
Conversation
Collaborator
|
Thanks for the focused Windows reproduction and narrow terminal change. Problems
Suggested changes
Automated hermes-sweeper review. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On Windows, build the
LocalEnvironmentsnapshot with non-login Git Bash instead ofbash -l.Git for Windows'
/etc/profilecan replace the native parentPATH. Desktop and collaboration hosts commonly inject a bundled CLI directory into that parent environment before launching an ACP agent. The login shell discarded that directory before Hermes captured its terminal snapshot, so a CLI that existed and was present in the ACP process environment becamecommand not foundinside the terminal tool.Configured shell init files are already prepended explicitly. This change keeps that behavior while limiting the non-login snapshot to Windows; POSIX retains the existing login-shell path.
Real integration proof
Reproduced on Windows 10 with:
0922869abe9f170879276588f3c4c51c292e230fhermes-acp.exe0.19.0 launched directlyopenai-codex:gpt-5.6-solPATHBefore the change, native and non-login Git Bash could resolve
buzz, while the login snapshot could not. After the change, a fresh process against current Hermesmainreturned:The full ACP turn then published a visible, attributed Buzz thread reply with the exact requested token.
The separate Git Bash startup-probe hang encountered in the same proof is already covered by #69083 and is intentionally not duplicated here.
Tests
2 passedruff check tools/environments/local.py tests/tools/test_local_env_windows_msys.py: passed4 failed, 36 passed4 failed, 38 passedThe four failures are unchanged Windows-host baseline assumptions in existing tests; this patch introduced no new failures.
Type of change
Scope