fix(discord): drain pending voice input before disconnect - #68901
Closed
toomij99 wants to merge 1 commit into
Closed
fix(discord): drain pending voice input before disconnect#68901toomij99 wants to merge 1 commit into
toomij99 wants to merge 1 commit into
Conversation
alt-glitch
added
type/bug
toomij99
marked this pull request as ready for review
July 21, 2026 20:39
23 tasks
toomij99
marked this pull request as draft
July 22, 2026 04:39
Collaborator
|
Merged into main via consolidated salvage PR #73517 (merge Your contribution is credited to you in git history. Thank you! Closing this PR as merged-via-salvage. |
Contributor
Author
|
Thank you for the salvage and for preserving authorship |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
leave_voice_channel()stopped theVoiceReceiverand cancelled its listener before audio that had not reached the silence threshold could be transcribed.Validation
tests/gateway/test_voice_command.py::TestVoiceReceiver::test_flush_pending_returns_recent_utterance_before_silencetests/gateway/test_voice_command.py::TestDiscordVoiceChannelMethods::test_leave_voice_channel_processes_pending_audio_before_disconnectruff check plugins/platforms/discord/adapter.py tests/gateway/test_voice_command.pyBaseline note
The focused file currently has four unrelated pre-existing failures in
/voiceresponse-text assertions: current code returns localization keys such asgateway.voice.status_modeandgateway.voice.help, while those tests expect English literals. The full run after this change was185 passed, 4 failed.