Repository navigation
Conversation
|
Verified head SHA 0448249b matches PR. tests/gateway/test_session_policy_remote_cwd.py: 11 passed, 0 failed via scripts/run_tests.sh. ruff clean on changed files. |
alt-glitch
added
area/sessions
nateEc
marked this pull request as ready for review
October 19, 2026 02:24
• 容器会话的创建、恢复和逐轮就绪检查不再依赖宿主目录是否存在；本地和自动挂载模式仍保持宿主校验。 • 显式 Docker 挂载目标及子目录优先于宿主路径启发式，避免有效目录被回退为 /root。 • 新增回归先红后绿；邻近 53 个测试通过，两个进程级失败在未修改 main 上同样复现，12 项检查通过。
• 贯通会话创建、策略恢复、终端执行和文件工具，覆盖三种容器路径及含中文空格的宿主挂载目录。 • 验证目录持久化、文件字节一致性及容器清理；旧基线三例均因目录校验失败。 • Docker Desktop 实机 10 个测试和网关 11 个回归通过，12 项检查通过。
nateEc
force-pushed
the
codex/fix-container-session-cwd
branch
from
October 23, 2026 06:25
5146be2 to
a8fc6fe
Compare
13 of 20 tasks
合并当前主线，保留容器命名空间修复及 Desktop 工作区选择和重建的新增用例。 验证 12 项真实 Docker 测试及相关测试，共 87 项通过，3 项 Linux 专属测试跳过。 原主线复现 3 项容器目录失败，2 项宿主目录对照通过；15 项仓库检查通过。
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140527.
A Docker profile can use its container workspace even when that path does not exist on the gateway host. Explicit volume destinations under /home or /Users also survive cwd sanitization. Host-local and automatic host-mount modes retain their existing-directory checks.
Session creation, frozen-policy restore, shared workspace readiness and managed-worker admission validate paths in the correct namespace. Preserve the structured missing-host-folder error and never-run settlement behavior. The regressions drive real terminal/config consumers and the managed admission guard; only worker execution is stubbed there.
Current-main reconciliation — 2026-11-07
Merged main
122fc40fb06b722b4debedac429c57336cff61aeinto this branch, retaining both this PR's container-workspace probes and main's new Desktop workspace selection/recreation tests. Original commit authorship is preserved. Tested head:7d9a87c73c76bfd7391fee5786e84ffae5ab432f.Validation
scripts/run_tests.sh tests/tools/test_docker_backend_real.py tests/gateway/test_session_policy_remote_cwd.py tests/gateway/test_docker_session_workspace.py --fail-on-skip -q -j 1: 47 passed, zero skips, including 12 real-container tests.debian:13-slim. Tested image ID:sha256:37e6c80085f82a8a7f1cea2b83f036d9c084a2cd3d5be1aa6fd56d7c6f8ad7ba.No change to host-side context-file discovery. Upstream Actions require maintainer approval; local verification is not an upstream-CI success claim.