Skip to content

fix(tools): apply managed config to per-turn terminal policy - #140698

Open
nateEc wants to merge 1 commit into
NousResearch:mainfrom
nateEc:codex/fix-managed-terminal-policy
Open

nateEc wants to merge 1 commit into
NousResearch:mainfrom
nateEc:codex/fix-managed-terminal-policy

Conversation

@nateEc

@nateEc nateEc commented Oct 17, 2026 •

Copy link
Copy Markdown

Status — covered on main (2026-11-07)

The terminal-policy half of #140174 is now implemented independently on main by bd2fb30d2e. Main applies the managed terminal overlay last, preserving user siblings and explicit managed image pinning. It also handles an unreadable profile .env when the managed backend is pinned.

Revalidated against main 122fc40fb06b722b4debedac429c57336cff61ae with production terminal/gateway/config code unchanged:

  • All 3 original PR regression cases pass, exercising real routed scopes, terminal/media consumers, policy refresh and corrupt-user-config refusal.
  • 32 tests pass, 0 failures, including current main's managed/multiplex terminal scope, effective config and TUI entrypoint suites.
  • Native macOS, isolated PM-built Python 3.14, scripts/run_tests.sh, retries disabled. No live Docker claim for this verification.

The original regression file was exported outside the checkout so main's own newer tests remained intact. The branch is retained as requested by its owner; its merge conflict reflects the overlapping upstream fix. Merging the older implementation is no longer necessary. The plugin-dependency half of the issue remains separate (#140180).

@whyyagswhy

Copy link
Copy Markdown

Verified head SHA 185f5df matches PR. tests/tools/test_terminal_scope_managed.py: 3 passed, 0 failed via scripts/run_tests.sh. ruff clean on changed files.

@alt-glitch alt-glitch added area/config Config system, migrations, profiles backend/docker Docker container execution comp/tools Tool registry, model_tools, toolsets P2 Medium — degraded but workaround exists type/bug Something isn't working labels Oct 17, 2026
@nateEc
nateEc marked this pull request as ready for review October 19, 2026 02:25
• 复用无默认值的有效配置加载器,使托管后端、镜像及挂载覆盖 profile 配置,并保持来源隔离。

• 保留用户配置解析失败时拒绝执行的约束,覆盖管理员修改后的重新解析及损坏配置恢复路径。

• 新增回归在 main 上复现两处 local 后端错误;修复后相关 22 个测试和 12 项检查通过。
@nateEc
nateEc force-pushed the codex/fix-managed-terminal-policy branch from 185f5df to b4c2778 Compare October 26, 2026 06:11
@alt-glitch alt-glitch added the tool/terminal Terminal execution and process management label Nov 8, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles backend/docker Docker container execution comp/tools Tool registry, model_tools, toolsets P2 Medium — degraded but workaround exists tool/terminal Terminal execution and process management type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants