Repository navigation
Conversation
|
Verified head SHA 185f5df matches PR. tests/tools/test_terminal_scope_managed.py: 3 passed, 0 failed via scripts/run_tests.sh. ruff clean on changed files. |
nateEc
marked this pull request as ready for review
October 19, 2026 02:25
• 复用无默认值的有效配置加载器,使托管后端、镜像及挂载覆盖 profile 配置,并保持来源隔离。 • 保留用户配置解析失败时拒绝执行的约束,覆盖管理员修改后的重新解析及损坏配置恢复路径。 • 新增回归在 main 上复现两处 local 后端错误;修复后相关 22 个测试和 12 项检查通过。
nateEc
force-pushed
the
codex/fix-managed-terminal-policy
branch
from
October 26, 2026 06:11
185f5df to
b4c2778
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status — covered on main (2026-11-07)
The terminal-policy half of #140174 is now implemented independently on main by bd2fb30d2e. Main applies the managed terminal overlay last, preserving user siblings and explicit managed image pinning. It also handles an unreadable profile .env when the managed backend is pinned.
Revalidated against main
122fc40fb06b722b4debedac429c57336cff61aewith production terminal/gateway/config code unchanged:scripts/run_tests.sh, retries disabled. No live Docker claim for this verification.The original regression file was exported outside the checkout so main's own newer tests remained intact. The branch is retained as requested by its owner; its merge conflict reflects the overlapping upstream fix. Merging the older implementation is no longer necessary. The plugin-dependency half of the issue remains separate (#140180).