Skip to content

feat(image-gen): add Codex CLI backend for image generation#14046

Closed
zychenzy wants to merge 1 commit into
NousResearch:mainfrom
zychenzy:feat/codex-cli-image-gen-provider
Closed

feat(image-gen): add Codex CLI backend for image generation#14046
zychenzy wants to merge 1 commit into
NousResearch:mainfrom
zychenzy:feat/codex-cli-image-gen-provider

Conversation

@zychenzy

@zychenzy zychenzy commented Apr 22, 2026

Copy link
Copy Markdown

Summary

Add a bundled codex-cli image generation backend so Hermes can use Codex CLI's built-in image generation through the user's local Codex/ChatGPT login.

What this changes

  • add plugins/image_gen/codex_cli backend
  • detect availability via codex login status
  • resolve CODEX_HOME from env, config, or default ~/.codex
  • run generation through codex exec --json --full-auto --enable image_generation
  • discover generated image files from thread output or newly created files
  • add focused provider tests for success/error paths and config/env handling

Sample config

image_gen:
  provider: codex-cli
  model: codex-cli-default
  codex_cli:
    codex_home: ~/.codex-hermes

Files touched

  • plugins/image_gen/codex_cli/__init__.py
  • plugins/image_gen/codex_cli/plugin.yaml
  • tests/plugins/image_gen/test_codex_cli_provider.py

Validation

  • pytest -q tests/plugins/image_gen tests/agent/test_image_gen_registry.py tests/hermes_cli/test_plugin_scanner_recursion.py tests/tools/test_image_generation.py tests/tools/test_image_generation_env.py
  • 126 passed

@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins tool/vision Vision analysis and image generation labels Apr 22, 2026
@alt-glitch alt-glitch mentioned this pull request Apr 22, 2026
Closed
@alt-glitch

alt-glitch commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Related to #14047 (Codex auth fallback in OpenAI provider) — different approach to #11195. This adds a standalone codex-cli provider; #14047 extends the OpenAI provider.

@alt-glitch alt-glitch mentioned this pull request Apr 23, 2026
Closed
@teknium1

teknium1 commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Thanks for the thoughtful implementation and focused provider tests.

This automated hermes-sweeper review is closing the PR under the standing in-tree third-party integration policy:

  • The change adds a bundled plugins/image_gen/codex_cli backend for the external Codex CLI (plugins/image_gen/codex_cli/__init__.py:170). New vendor/product integrations must ship as standalone plugins rather than expanding this repository's bundled plugin surface (AGENTS.md:797).
  • Hermes already ships a supported Codex-auth image-generation option as plugins/image_gen/openai-codex/, added by eda5ae5a5e25f855e672fd3592f3194c5d911894 and selectable through hermes tools.
  • If maintaining the local-CLI approach is useful, please publish it as a standalone plugin repo installable under ~/.hermes/plugins/ or via a pip entry point; it can be promoted in #plugins-skills-and-skins.

Closed as not-planned per standing maintainer policy (in-tree-provider-integration). This is a design-direction decision, not a code-quality judgment — see the Contribution Rubric in AGENTS.md for what the project is looking for. If you believe this policy was misapplied to your change, comment here and a maintainer will take a look.

@teknium1 teknium1 closed this Jul 12, 2026
@teknium1 teknium1 added the sweeper:not-planned Sweeper: closed per standing maintainer policy (design direction) label Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have sweeper:not-planned Sweeper: closed per standing maintainer policy (design direction) tool/vision Vision analysis and image generation type/feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zychenzy @alt-glitch @teknium1